Don't use an IntSet for the regexps when mapping atoms to regex#60
Merged
masklinn merged 1 commit intoua-parser:mainfrom Mar 14, 2026
Merged
Conversation
re2 uses a straight vector and doesn't bother any further, I assume this was originally a hashset due to concerns about duplicates, then it got converted through to an `IntSet` as that got used for the propagation state. Saves an allocation and a minor amount of indirection in extend, but doesn't otherwise seem to have a significant effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re2 uses a straight vector and doesn't bother any further, I assume this was originally a hashset due to concerns about duplicates, then it got converted through to an
IntSetas that got used for the propagation state.Saves an allocation and a minor amount of indirection in extend, but doesn't otherwise seem to have a significant effect.