fix: add email field to slack_search_users filter#24
Open
hashiyaman wants to merge 1 commit intoubie-oss:mainfrom
Open
fix: add email field to slack_search_users filter#24hashiyaman wants to merge 1 commit intoubie-oss:mainfrom
hashiyaman wants to merge 1 commit intoubie-oss:mainfrom
Conversation
Previously, slack_search_users only matched against username, display_name, real_name, and display_name_normalized. Users searching by email address (e.g. contractors with non-standard email domains) would get no results. Add profile.email to the search filter so that email-based lookups work correctly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
slack_search_usersnow matches againstprofile.emailin addition toname,real_name,display_name, anddisplay_name_normalizedtsubasa.nakamura@ubie-partners.com)Background
Contractors/freelancers whose email domain differs from the main org (e.g.
@ubie-partners.com) could not be found viaslack_search_usersbecause the tool only searched name fields. This caused downstream workflows (n8n Activity Report generation) to fail Slack ID resolution for ~176 contractor accounts.Changes
src/index.ts: Adduser.profile.emailto the search filter inslack_search_usersTest plan
tsubasa.nakamura@ubie-partners.com→ should return the user@ubie-partners.com→ should return matching users中村翼→ should return the user🤖 Generated with Claude Code