alphabet: handle large ratio of alphabet to seps#30
Merged
manigandham merged 1 commit intoullmark:masterfrom Apr 17, 2021
ethomson:master
Merged
alphabet: handle large ratio of alphabet to seps#30manigandham merged 1 commit intoullmark:masterfrom ethomson:master
manigandham merged 1 commit intoullmark:masterfrom
ethomson:master
Conversation
When using a custom alphabet, there may be a large ratio of alphabet characters to separator characters. When the ratio is larger than 3.5, the alphabet and separators are adjusted. However, if we use integer arithmetic, we may not do the adjustment when the ratio is > 3.5 but < 4. Use floating point arithmetic to do this comparison. Include a test where the ratio of alphabet characters to separator characters is 3.714.
Owner
|
@ethomson Thanks for the PR, I'll have a look! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a custom alphabet, there may be a large ratio of alphabet
characters to separator characters. When the ratio is larger than 3.5,
the alphabet and separators are adjusted.
However, if we use integer arithmetic, we may not do the adjustment when
the ratio is > 3.5 but < 4. Use floating point arithmetic to do this
comparison.
Include a test where the ratio of alphabet characters to separator
characters is 3.714.