Skip to content

Remove net461 target #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manigandham merged 2 commits into from
Mar 31, 2022
Merged

Remove net461 target #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aecd4b7
remove net461 framework target
manigandham Mar 31, 2022
5753a97
set lang version to latest
manigandham Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Hashids.net/Hashids.net.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,17 @@
<PackageTags>ids;hash</PackageTags>
<RepositoryType>git</RepositoryType>
<RepositoryUrl>https://github.com/ullmark/hashids.net</RepositoryUrl>
<TargetFrameworks>net461;netstandard2.0;net5.0;net6.0</TargetFrameworks>
<TargetFrameworks>netstandard2.0;net5.0;net6.0</TargetFrameworks>
<OutputType>Library</OutputType>
<LangVersion>9</LangVersion>
<LangVersion>latest</LangVersion>
<IncludeSymbols>true</IncludeSymbols>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<!-- CS1591: Missing XML comment for publicly visible type or member -->
<NoWarn>$(NoWarn);CS1591</NoWarn>
</PropertyGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'net461' OR '$(TargetFramework)' == 'netstandard2.0'">
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
<PackageReference Include="System.Buffers" Version="4.5.1" />
</ItemGroup>

Expand Down
2 changes: 1 addition & 1 deletion test/Hashids.net.benchmark/Hashids.net.benchmark.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<OutputType>Exe</OutputType>
<TargetFrameworks>net48;net5.0</TargetFrameworks>
<IsPackable>false</IsPackable>
<LangVersion>9</LangVersion>
<LangVersion>latest</LangVersion>
</PropertyGroup>

<ItemGroup>
Expand Down
9 changes: 3 additions & 6 deletions test/Hashids.net.test/Hashids.net.test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<!--
The main project targets net461, netstandard2.0, net5.0 and net6.0
As test projects cannot target netstandard the net48 target is used as a stand-in for that.
-->
<TargetFrameworks>net461;net48;net5.0;net6.0</TargetFrameworks>
<!-- net48 target is used as a stand-in for testing netstandard2.0 -->
<TargetFrameworks>net48;net5.0;net6.0</TargetFrameworks>
<IsPackable>false</IsPackable>
<LangVersion>9</LangVersion>
<LangVersion>latest</LangVersion>
</PropertyGroup>

<ItemGroup>
Expand Down
⚡