Refactoring and optimizations#63
Merged
manigandham merged 1 commit intoullmark:masterfrom Apr 2, 2022
KeterSCP:optimizations
Merged
Refactoring and optimizations#63manigandham merged 1 commit intoullmark:masterfrom KeterSCP:optimizations
manigandham merged 1 commit intoullmark:masterfrom
KeterSCP:optimizations
Conversation
manigandham
approved these changes
Apr 2, 2022
Collaborator
|
Thanks @KeterSCP, this looks good. Please hold off on anymore changes for now. I think the performance is fine at this point and I want to get the latest changes released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR usages of ArrayPool were replaced by stackallocs. In order to avoid StackOverflowException if requested buffer is too large, we will fallback to simple arrays.
Having the same memory allocations we gain 5-20% speed improvements.
Base:
PR:
