Skip to content

fix: use subprocess instead of os.system in resume.py #13730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glenn-jocher merged 2 commits into from
Apr 16, 2026
+16 −6
Merged

fix: use subprocess instead of os.system in resume.py #13730

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d38b5fe
fix: V-001 security vulnerability
orbisai0security Apr 12, 2026
ed50ceb
Merge branch 'master' into fix-fix-v-001-command-injection-aws-resume
glenn-jocher Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions utils/aws/resume.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# Resume all interrupted trainings in yolov5/ dir including DDP trainings
# Usage: $ python utils/aws/resume.py

import os
import subprocess
import sys
from pathlib import Path

Expand Down Expand Up @@ -34,10 +34,20 @@

if ddp: # multi-GPU
port += 1
cmd = f"python -m torch.distributed.run --nproc_per_node {nd} --master_port {port} train.py --resume {last}"
cmd = [
"python",
"-m",
"torch.distributed.run",
"--nproc_per_node",
str(nd),
"--master_port",
str(port),
"train.py",
"--resume",
str(last),
]
else: # single-GPU
cmd = f"python train.py --resume {last}"
cmd = ["python", "train.py", "--resume", str(last)]

cmd += " > /dev/null 2>&1 &" # redirect output to dev/null and run in daemon thread
print(cmd)
os.system(cmd)
print(" ".join(cmd))
subprocess.Popen(cmd, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL) # run in daemon thread
Loading
⚡