Merged
Conversation
Member
配置保留
singular 默认为 true,如果不支持 Proxy 的环境还被配置了 singular false, 直接警告或者报错 |
kuitos
requested changes
Mar 16, 2020
kuitos
pushed a commit
that referenced
this pull request
Mar 26, 2020
kuitos
pushed a commit
that referenced
this pull request
Mar 29, 2020
kuitos
pushed a commit
that referenced
this pull request
Mar 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesDescription of change
ref #182
1. IE 下需要主应用需要引入以下 polyfill
不能使用 https://polyfill.io/ 提供的 fetch
2. 支持 proxy 沙箱自动退化为 snapshot 沙箱
是否更改
jsSandbox为jsSandbox: boolean | 'proxy' | 'snapshot'snapshot 应该是强制要求
singular为true的,无法支持多应用共存给沙箱增加生命周期钩子方便调试 TODO
3. 需要增加 IE 的 test case TODO