5% min starting point#1
Conversation
evan-forbes
left a comment
evan-forbes
left a comment
There was a problem hiding this comment.
We still need to add some more testing, and let's also investigate if #103 is also needed.
This is a perfect start tho, great work!
Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>
| const ( | ||
| AccountAddressPrefix = "chihuahua" | ||
| Name = "chihuahua" | ||
| upgradeName = "" |
There was a problem hiding this comment.
In #81 they named this "moneta-alpha" but ours doesn't have a name, so I left it blank.
There was a problem hiding this comment.
where is this used? Just to note that we will likely want to point this out when publishing our PR
|
what part of testutil/keeper/chihuahua.go did you comment out? The entire file? |
Yeah, the entire thing |
|
Let's also go ahead and add a simple changelog to indicate which changes have been included in this PR |
* add ability to add genesis accounts to the network config for integration testing * add the keyring signer * use the standard sdk way of integration testing * delete unused file * delete unused code
|
closing as we went with a different solution |
2 participants
Needs to be debugged, but it's a starting point modeled after Juno ChihuahuaChain#81