ICU-23371 Reduce the memory footprint subdivisionData in ValidIdentifiers#3938
Open
gvictor wants to merge 1 commit intounicode-org:mainfrom
Open
ICU-23371 Reduce the memory footprint subdivisionData in ValidIdentifiers#3938gvictor wants to merge 1 commit intounicode-org:mainfrom
gvictor wants to merge 1 commit intounicode-org:mainfrom
Conversation
mihnita
changed the title
mihnita
reviewed
Apr 13, 2026
icu4j/main/core/src/main/java/com/ibm/icu/impl/ValidIdentifiers.java
Outdated
Show resolved
Hide resolved
Member
|
@jabagawee FYI |
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
gvictor
changed the title
…iers HashSet internally uses HashMap requests extra memory footprints for each entry. Use Set.copyOf(Set) to avoid the memory overhead The heap dump shows ~351kB reduction. Also, use Map.copyOf(map) instead of HashMap. It reduces the memory footprint by ~52kB.
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HashSet internally uses HashMap requests extra memory footprints for each entry. Use Set.copyOf(Set) to avoid the memory overhead The heap dump shows ~351kB reduction.
Also, use Map.copyOf(map) instead of HashMap. It reduces the memory footprint by ~52kB.
Checklist