ICU-23368 Update JDK version for tools to 21#3942
Open
mihnita wants to merge 3 commits intounicode-org:mainfrom
Open
ICU-23368 Update JDK version for tools to 21#3942mihnita wants to merge 3 commits intounicode-org:mainfrom
mihnita wants to merge 3 commits intounicode-org:mainfrom
Conversation
We want to be able to control the JDK version separately. Because errorprone will depend on the upstream errorprone, which requires JDK 21, while the API reporting in `build` is best to run with the same jdk version that the ICU released artifacts use.
mihnita
commented
Apr 14, 2026
| <id>requires_jdk21</id> | ||
| <activation> | ||
| <!-- Using ${enforcer.requireJavaToolsVersion} does not work. Bug? --> | ||
| <jdk>[21,)</jdk> |
Contributor
Author
There was a problem hiding this comment.
Auto-activate profile if jdk version > 21
mihnita
commented
Apr 14, 2026
| <jdk>[21,)</jdk> | ||
| </activation> | ||
| <modules> | ||
| <module>errorprone_report</module> |
Contributor
Author
There was a problem hiding this comment.
Only try building this module for jdk 21 or higher.
That's because errorprone itself requires jdk 21.
mihnita
commented
Apr 14, 2026
| <!-- Dependencies versions --> | ||
| <commons-cli.version>1.11.0</commons-cli.version> | ||
| <error_prone.version>2.25.0</error_prone.version> | ||
| <error_prone.version>2.49.0</error_prone.version> |
Contributor
Author
There was a problem hiding this comment.
Updating to the latest errorprone.
Which requires jdk 21.
what we had worked with jdk 11, but was more that one year old.
mihnita
commented
Apr 14, 2026
| <compilerArgs> | ||
| <arg>-XDcompilePolicy=simple</arg> | ||
| <arg>-XDaddTypeAnnotationsToSymbol=true</arg> | ||
| <arg>--should-stop=ifError=FLOW</arg> |
Contributor
Author
There was a problem hiding this comment.
These new flags are required by the new errorprone versions
mihnita
commented
Apr 14, 2026
| See https://github.com/google/error-prone/issues/4256 | ||
| --> | ||
| <arg>-Xplugin:ErrorProne -Xep:UnicodeEscape:OFF -Xep:InvalidBlockTag:OFF</arg> | ||
| <arg>-Xplugin:ErrorProne -Xep:UnicodeEscape:OFF -Xep:InvalidBlockTag:OFF -Xep:LabelledBreakTarget:WARN</arg> |
Contributor
Author
There was a problem hiding this comment.
New failure detected by the new errorprone
mihnita
commented
Apr 14, 2026
| <!-- Use <compilerArg> to pass flags to errorprone. See https://errorprone.info/docs/flags --> | ||
| <compilerArgs> | ||
| <arg>-XDcompilePolicy=simple</arg> | ||
| <arg>-XDaddTypeAnnotationsToSymbol=true</arg> |
Contributor
Author
There was a problem hiding this comment.
same 2 flags as above
Contributor
Author
|
I've added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ALLOW_MANY_COMMITS=true
Checklist