Conversation
There was a problem hiding this comment.
Hello @cosenal, thank you for submitting a PR to Mitiq! We will respond as soon as possible, and if you have any questions in the meantime, you can ask us on the Unitary Fund Discord.
|
Nice! It's failing here, not sure why. |
|
@nathanshammah Yes, I cancelled the workflow, because I saw it failing on the docs build, which I am investigating. I am leaving it as a Draft PR until the build is fixed. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2235 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 103 103
Lines 4730 4730
=======================================
Hits 4642 4642
Misses 88 88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Is this blocked by the PyData Sphinx theme action? |
|
@nathanshammah indeed – I have just dropped a comment there |
|
Since v0.15.4, the Sphinx theme enabled parallel write. The next blocking factor is Jupyter-cache not supporting parallel execution, see executablebooks/jupyter-cache#37 and sphinx-doc/sphinx#12481. |
c92ca46 to
8b5530d
Compare
|
@cosenal I'm confused by that ticket on jupyter-cache given they do support two parallel modes according to https://jupyter-cache.readthedocs.io/en/latest/using/cli.html#executing-the-notebooks. Maybe |
I am also confused by why the builds are passing now, and nothing has changed in jupyter-cache since 🤔 Maybe just a fortunate race condition. |
|
In order to get the build to work locally I (read Claude) had to make some alterations to avoid a race condition. See 7970a86. Once the issue was fixed I was able to run
|
|
I triggered a |
|
yes, no error. But that's the unpredictability of race conditions
running a |
|
Locally it failed with |
|
btw, this shouldn't block any release, it's just a nice to have, especially now that we are not running docs-build at every PR. |
|
for future reference, the docs-build on the GitHub worker succeeded ✅ |
Description
An attempt to speed up docs build (related to #2083, but not the same as that's about RTD).
It looks like the bottleneck is the notebook execution. MyST-NB is parallel-friendly, hence this attempt.
Some data points from testing this on my local machine (Apple M2 Pro):
time make docs-cleanLicense
Before opening the PR, please ensure you have completed the following where appropriate.
N/A - [ ] I added unit tests for new code.
N/A - [ ] I used type hints in function signatures.
N/A - [ ] I used Google-style docstrings for functions.
N/A - [ ] I updated the documentation where relevant.