206 no pre-decomposition of gates#209
Draft
jordandsullivan wants to merge 3 commits intomainfrom
Draft
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds benchmark circuits which contain gates outside our current target gateset and allow such circuits to bypass our existing validation checks before running by using the new flag for pre-decomposition of input gates (flexible on a catchier name for this flag), included in the benchmark parameters.
Still need to confirm that the gate counts are accurate, since we are no longer restricted to 2 qubit gates, but here are the results so far for the two chosen benchmarks, 18 qubit Shor's algorithm and 8 qubit random circuit:
Again it's a bit hard to see with the y-axes shared for both benchmarks, but there is some degree of separation visible across the different compilers.