Add qol changes#221
Open
Andre601 wants to merge 2 commits into
Open
Conversation
Andre601
added a commit
to Andre601/status-page
that referenced
this pull request
Aug 16, 2023
Contributor
|
@AnandChowdhary LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all would I like to mention that I have no idea if I made this right or not... Typescript is not my strong side (I have like 0 experience) and I made this within the GitHub editor...
With that out of the way, this PR addresses some of the suggestions I made in the past, namely upptime/upptime#569 and upptime/upptime#572, by not only changing the default status message to be no longer in the past tense ("was" isn't really accurate when the issue has just been created because of the site being down) but also adding new config options
issueTitleandissueBodyfor people to be able to change the respective text to what they prefer.It also adds new options
issuePrefixStatusDownandissuePrefixStatusDegradedto replace$PREFIXin issue title and body with an emoji/text based on the status (Down or degraded)Finally does it also add a simple check
metadata.end !== "unknown"to when checking if a maintenance issue is past its end-date to be closed.This should help setting a maintenance task with not yet known end date (Useful for maintenance that f.e. relies on outside/3rd party sources/hosts). This may also require changes to the status page to work...
I really hope this looks fine. If not, feedback and especially corrections are very welcome here!