-
Notifications
You must be signed in to change notification settings - Fork 9
Add rhel 10 support, combine workers+workers_gpu, remove jenkins, remove rhel 8 #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: pxe
Are you sure you want to change the base?
Changes from all commits
03aa218
b07ffde
5312ddf
1195d53
6fb4eb7
c8ae095
f2c7c36
b2bb61b
392ef24
277e6cf
0b18134
6db0b5a
0409aa9
501aa66
5c43d28
da8c4dc
803cb5a
ca0520d
679d4fe
91abe71
b6f8f6a
1967f52
5509fa7
bafe0cf
fabb189
3b901cc
6e42981
dad6dba
8fb8183
2a0151d
89c2d3d
9450f83
9ee755c
d57db05
d8253a1
83a6287
aa0f6e0
8dce801
f616997
6e7f2fb
c21ea49
527a0b9
cfe5757
ed5ce54
8e74853
2020305
e48d7d1
49bf4c5
80920c0
accd830
ff488e6
0677c87
5479735
1ef8d09
e793afa
385bfc5
f80f2ec
a4f7597
556c12a
ba55f32
a7f2367
5b11c82
bed6855
866c9ac
90a91b4
df177a7
fd862ff
5f46406
dc92c84
d5bdc73
6d3c232
7ae5474
44d0e10
f18dff3
2e1ff0d
37b930d
336f69f
0f4baf5
03be412
ed708e4
83f7c07
e43f2d1
cd3458d
904ca84
738597e
4586388
b733f8e
68d5e83
01137e1
be7cf17
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -11,6 +11,7 @@ galaxy_gid: 999 | |||||||||||
| replace_non_galaxy_999: true | ||||||||||||
|
|
||||||||||||
| telegraf_agent_package_state: latest | ||||||||||||
| telegraf_yum_gpgcheck: false | ||||||||||||
|
gsaudade99 marked this conversation as resolved.
|
||||||||||||
| telegraf_agent_tags: | ||||||||||||
| - tag_name: datacenter | ||||||||||||
| tag_value: rz | ||||||||||||
|
|
@@ -43,11 +44,11 @@ telegraf_plugins_default: | |||||||||||
| - name_suffix = "_alive" | ||||||||||||
|
|
||||||||||||
| java_packages: | ||||||||||||
| - java-11-openjdk | ||||||||||||
| - java-11-openjdk-devel | ||||||||||||
| - java-21-openjdk | ||||||||||||
|
Comment on lines
46
to
+47
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually we should be able to remove |
||||||||||||
|
|
||||||||||||
| # CVMFS | ||||||||||||
| cvmfs_role: client | ||||||||||||
| cvmfs_yum_releasever: "9" | ||||||||||||
| galaxy_cvmfs_repos_enabled: true | ||||||||||||
| galaxy_cvmfs_server_urls: | ||||||||||||
| - domain: galaxyproject.org | ||||||||||||
|
|
@@ -68,11 +69,12 @@ dynmotd_custom: | |||||||||||
|
|
||||||||||||
| # Docker | ||||||||||||
| docker_packages: | ||||||||||||
| - "docker-{{ docker_edition }}-3:25.0.0-1.el9" | ||||||||||||
|
gsaudade99 marked this conversation as resolved.
|
||||||||||||
| - "docker-{{ docker_edition }}-cli-1:25.0.5-1.el9" | ||||||||||||
| - "docker-{{ docker_edition }}-rootless-extras-25.0.5-1.el9" | ||||||||||||
| - "containerd.io" | ||||||||||||
| - docker-ce | ||||||||||||
| - docker-ce-cli | ||||||||||||
| - containerd.io | ||||||||||||
| - docker-buildx-plugin | ||||||||||||
| - docker-compose-plugin | ||||||||||||
| - docker-ce-rootless-extras | ||||||||||||
| docker_users: | ||||||||||||
| - centos | ||||||||||||
| - condor | ||||||||||||
|
|
@@ -105,6 +107,13 @@ autofs_service.enable: True | |||||||||||
| nfs_kernel_tuning: True | ||||||||||||
| nfs_kernel_tuning_parameters: | ||||||||||||
| sunrpc.tcp_max_slot_table_entries: 100 | ||||||||||||
| handy_groups: | ||||||||||||
| - group_name: galaxy | ||||||||||||
| group_gid: 999 | ||||||||||||
| handy_users: | ||||||||||||
| - user_name: galaxy | ||||||||||||
| user_uid: 999 | ||||||||||||
| user_group: galaxy | ||||||||||||
|
|
||||||||||||
| # usegalaxy_eu.handy.os_setup | ||||||||||||
| # ansible_root_cron | ||||||||||||
|
|
@@ -140,3 +149,8 @@ software_groups_to_install: | |||||||||||
| kernel_5_package: kernel-ml | ||||||||||||
|
|
||||||||||||
| docker_daemon_options: {} | ||||||||||||
|
|
||||||||||||
| # Devsec | ||||||||||||
| # Forsing group owenership to root. The role is for some reason trying to change it to "ssh_keys" | ||||||||||||
| # and this does not aligne with the base Rocky10 image | ||||||||||||
| ssh_host_keys_group: root | ||||||||||||
|
Comment on lines
+152
to
+156
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
I have removed the that code and tried this playbook. ---
- hosts: all
vars:
...
pre_tasks:
...
roles:
- role: usegalaxy_eu.handy.os_setup
vars:
enable_create_user: true
enable_powertools: true
enable_install_software: true
enable_grub: true
enable_kernel_5: "{{ true if (ansible_facts['distribution_major_version'] < '9') else false }}"
- geerlingguy.repo-epel # Install EPEL
- usegalaxy-eu.autoupdates # keep all of our packages up to date REMOVED until latest kernel is supported in dnbd3
- usegalaxy-eu.dynmotd
- influxdata.chrony
- usegalaxy-eu.telegraf
- devsec.hardening.ssh_hardening
post_tasks:
- name: Get owner and group for SSH host keys
ansible.builtin.stat:
path: "{{ item }}"
loop:
- /etc/ssh/ssh_host_rsa_key
- /etc/ssh/ssh_host_ecdsa_key
- /etc/ssh/ssh_host_ed25519_key
- /etc/ssh/ssh_host_rsa_key.pub
- /etc/ssh/ssh_host_ecdsa_key.pub
- /etc/ssh/ssh_host_ed25519_key.pub
register: ssh_host_keys_stat
- name: Debug SSH host key ownership
ansible.builtin.debug:
var: ssh_host_keys_statAnd I am getting gid 0 and uid 0 for the host keys.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Now that I puzzle it, this might be SELinux. Have you tried with it already disabled?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was reviewing the rest of the PR and found this. Maybe that line had something to do with the discrepance before it was modified? |
||||||||||||
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| --- | ||
| ssh_permit_root_login: "no" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,7 +36,7 @@ | |
| dest: /etc/ssh/ | ||
| mode: 0600 | ||
| owner: root | ||
| group: ssh_keys | ||
| group: root | ||
| with_items: | ||
| - ssh_host_ecdsa_key | ||
| - ssh_host_ed25519_key | ||
|
|
@@ -60,49 +60,9 @@ | |
| tasks: | ||
| - ansible.builtin.include_role: | ||
| name: cloudinit | ||
| when: "not ('pxe' in group_names or 'kvm' in group_names)" | ||
| when: "'cloud' in group_names" | ||
| - ansible.builtin.include_role: | ||
| name: cloudinit-pxe | ||
| when: "'pxe' in group_names" | ||
|
Comment on lines
60
to
66
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think it's worth changing it if things are working, but still I wanted to comment that this whole block seems to be a bit misplaced. Shouldn't But let's not touch it now if it works, this is very minor. |
||
| roles: | ||
| - lock-root | ||
|
|
||
| - name: HTCondor cluster. | ||
| hosts: workers-gpu:workers:&internal:!pxe # Hosts that are in (workers or workers-gpu) and internal and not in pxe | ||
| vars: | ||
| internal: true | ||
| vars_files: | ||
| - "group_vars/all.yml" | ||
| - "group_vars/condor.yml" | ||
| - "secret_group_vars/internal.yml" | ||
| handlers: | ||
| - name: Reload HTCondor | ||
| when: "'condor_service' in service_facts.ansible_facts.services and \ | ||
| service_facts.ansible_facts.services['condor.service'].state == 'running'" | ||
| become: true | ||
| ansible.builtin.service: | ||
| name: condor | ||
| state: reloaded | ||
| pre_tasks: | ||
| - name: Ensure the HTCondor configuration directory exists. | ||
| become: true | ||
| ansible.builtin.file: | ||
| path: /etc/condor | ||
| state: directory | ||
| owner: root | ||
| group: root | ||
| mode: "0755" | ||
| - name: Template HTCondor configuration. | ||
| become: true | ||
| ansible.builtin.template: | ||
| src: htcondor/condor_config.local.j2 | ||
| dest: /etc/condor/condor_config.local | ||
| owner: root | ||
| group: root | ||
| mode: "0644" | ||
| notify: Reload HTCondor | ||
| - name: Check if HTCondor is running. | ||
| ansible.builtin.service_facts: | ||
| register: service_facts | ||
| roles: | ||
| - grycap.htcondor | ||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to keep the old, explicit structure, where you could also decide to not use generic, I remember there was a discussion about this with @domgz
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also prefer to keep
generichere.Using
allwould also make it more difficult to implement ADR #3.