fix (db): update db-migration to create swaps i823#1301
Open
JustKuzya wants to merge 8 commits into
Open
Conversation
JustKuzya
commented
Jun 4, 2026
JustKuzya
commented
Collaborator
- add guide for testing the database upgrade with containerized Postgres DBMS
- create migration script for swaps
- verify that the script works for SQLite and containerized Postgres
- add guide for testing the database upgrade with containerized postgres DBMS - create migration script for swaps - verify that the script works for SQLite and containerized Posgres
keithmanville
left a comment
keithmanville
left a comment
Collaborator
There was a problem hiding this comment.
I was expecting to see the JobSwaps ORM object in db/models/jobs.py and changes to the response schema in v1/jobs/schema.py. Did you forget to commit? It looks like you had this done if you generated the alembic script from the ORM.
Lint and format the frontend using npm run lint and npm run format from the src/frontend directory. Perform check only using npm run lint:check and npm run format:check. Updated `DEVELOPER.md` to note lint and format rules. Updated all frontend packages. Note: eslint is incompatible with node v23. Added .nvmrc so nvm can be used to to switch to node v22. Added short explanation in frontend README.
Added frontend-checks.yml which runs the lint:check and format:check for PRs.
- added method doc-strings - changed the commit messafge structure to space-less one
- create ORM mapping in model - regenerate upgrade script
- update the model with job_id+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.