This repository was archived by the owner on Mar 5, 2024. It is now read-only.
agent: fix #229: ensure deferred funcs run + cleanup#300
Merged
Joseph-Irving merged 2 commits intouswitch:masterfrom May 18, 2020
Merged
agent: fix #229: ensure deferred funcs run + cleanup#300Joseph-Irving merged 2 commits intouswitch:masterfrom
Joseph-Irving merged 2 commits intouswitch:masterfrom
Conversation
This fixes uswitch#229 while also cleaning up the run logic to catch the error returned by server.Serve() and log when iptables changes are being undone.
charlievieth
force-pushed
the
cev/fix-agent-run
branch
from
ab8df71 to
db78807
Compare
Handle server shutdown directly in the run() command and log any errors. Previously, the code relied on a deferred call to close to stop the server and errors were ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #229 while also cleaning up the run logic to catch the error returned by server.Serve() and log when iptables changes are being undone.
This also changes the agent to handle server shutdown directly in the
run()command and log any errors. Previously, the code relied on a deferred call toStop()and errors were ignored.