Skip to content
This repository was archived by the owner on Mar 5, 2024. It is now read-only.

Add dynamic loading of TLS certificates#366

Merged
Joseph-Irving merged 2 commits intouswitch:masterfrom
abursavich:tls-cert-rotation
Mar 16, 2020
Merged

Add dynamic loading of TLS certificates#366
Joseph-Irving merged 2 commits intouswitch:masterfrom
abursavich:tls-cert-rotation

Conversation

@abursavich
Copy link
Copy Markdown
Contributor

Builds on #364
Fixes #365

@abursavich
Copy link
Copy Markdown
Contributor Author

Initial push used TTL to refresh certs.
Second push switched to fsnotify.
Third push added tests.

@abursavich abursavich requested a review from rhysemmas February 4, 2020 23:57
@pingles
Copy link
Copy Markdown
Contributor

pingles commented Feb 17, 2020

Nice, thanks for contributing @abursavich. Could someone from @tombooth / @uswitch/cloud take a look when you can please.

@abursavich
Copy link
Copy Markdown
Contributor Author

Updated to reflect changes in "parent" PR.

@abursavich
Copy link
Copy Markdown
Contributor Author

I can't access the CI output and the tests pass locally. I can push a no-op change to make it re-run?

Copy link
Copy Markdown
Contributor

@Joseph-Irving Joseph-Irving left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this feature!
lgtm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update TLS configs when certs are updated on disk

3 participants