split: reject a zero chunk count for -n l/N and r/N#12613
Merged
Conversation
`split -n l/0` and `split -n r/0` aborted with a divide-by-zero panic (`num_bytes / num_chunks` in `n_chunks_by_line` and `i % num_chunks` in `n_chunks_by_line_round_robin`). `NumberType::from` validated `N > 0` for the bare `N` / `K/N` forms but not for the `l/N` and `r/N` forms, so a zero count reached the chunk arithmetic. Reject `num_chunks == 0` in those two branches, returning `NumberTypeError::NumberOfChunks` like the bare-`N` form, which matches GNU (`split: invalid number of chunks: '0'`, exit 1) and validates up front rather than crashing while reading input.
|
GNU testsuite comparison: |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12612
split -n l/0andsplit -n r/0aborted with a divide-by-zero panic:NumberType::fromrejected a zero count for the bareN/K/Nforms but not forl/Nandr/N, sonum_chunks == 0reached the chunk arithmetic.Reject
num_chunks == 0in those two branches too, returningNumberTypeError::NumberOfChunkslike the bare-Nform — now matching GNU (split: invalid number of chunks: '0', exit 1). Adds unit + integration regression tests.