Skip to content

nice: untangle complex match#12916

Merged
sylvestre merged 2 commits into
uutils:mainfrom
cakebaker:nice_untangle_match
Jun 19, 2026
Merged

nice: untangle complex match#12916
sylvestre merged 2 commits into
uutils:mainfrom
cakebaker:nice_untangle_match

Conversation

@cakebaker

Copy link
Copy Markdown
Contributor

This PR untangles a complex match by moving some logic to a let else so that we can match on a single value instead of two. It also removes a mut by using two variables instead of one.

@oech3

oech3 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Do we still avoid parsing twice?

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/rm/many-dir-entries-vs-OOM is now being skipped but was previously passing.
Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.

@cakebaker

Copy link
Copy Markdown
Contributor Author

@oech3 which parsing do you mean? The parsing of the value of --adjustment?

@oech3

oech3 commented Jun 16, 2026 via email

Copy link
Copy Markdown
Contributor

@sylvestre sylvestre merged commit a037a0c into uutils:main Jun 19, 2026
175 checks passed
@cakebaker cakebaker deleted the nice_untangle_match branch June 19, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants