Skip to content

sum: take metadata from fd instead of path#12948

Closed
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:sum-toctou
Closed

sum: take metadata from fd instead of path#12948
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:sum-toctou

Conversation

@oech3

@oech3 oech3 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Closes #12947

@oech3 oech3 force-pushed the sum-toctou branch 3 times, most recently from 14a5ebf to bdaf420 Compare June 17, 2026 12:07
@codspeed-hq

codspeed-hq Bot commented Jun 17, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 323 untouched benchmarks
⏩ 46 skipped benchmarks1


Comparing oech3:sum-toctou (31ce44d) with main (ecfaf5a)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/cp/sparse-2 is now passing!
Congrats! The gnu test tests/tail/pipe-f is now passing!
Note: The gnu test tests/misc/write-errors was skipped on 'main' but is now failing.

@oech3 oech3 force-pushed the sum-toctou branch 6 times, most recently from 05a6a32 to 31ce44d Compare June 17, 2026 14:06
@oech3 oech3 closed this Jun 17, 2026
@oech3 oech3 deleted the sum-toctou branch June 17, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sum: path.is_dir() causes TOCTOU race

1 participant