Skip to content

tee: remove ErrorKind::Other, simplify already discarded Result#12953

Merged
sylvestre merged 1 commit into
uutils:mainfrom
oech3:tee-1
Jun 18, 2026
Merged

tee: remove ErrorKind::Other, simplify already discarded Result#12953
sylvestre merged 1 commit into
uutils:mainfrom
oech3:tee-1

Conversation

@oech3

@oech3 oech3 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

This should avoid confusion caused by strange usage of ErrorKind::Other.
Closes #12952 .

@oech3 oech3 force-pushed the tee-1 branch 2 times, most recently from ece7428 to 1d64260 Compare June 17, 2026 16:40
@codspeed-hq

codspeed-hq Bot commented Jun 17, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 323 untouched benchmarks
⏩ 46 skipped benchmarks1


Comparing oech3:tee-1 (dd23e86) with main (8464759)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3 oech3 force-pushed the tee-1 branch 4 times, most recently from 6e972ce to 2d21358 Compare June 17, 2026 16:50
@oech3 oech3 marked this pull request as ready for review June 17, 2026 17:05
@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/retry (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)

@oech3 oech3 changed the title tee: simplify already discarded Result tee: ErrorKind::Other, simplify already discarded Result Jun 17, 2026
@oech3 oech3 changed the title tee: ErrorKind::Other, simplify already discarded Result tee: remove ErrorKind::Other, simplify already discarded Result Jun 17, 2026
@oech3 oech3 force-pushed the tee-1 branch 4 times, most recently from 9e6e286 to 5b9dd35 Compare June 18, 2026 00:41
@sylvestre sylvestre merged commit 0624e58 into uutils:main Jun 18, 2026
175 checks passed
@oech3 oech3 deleted the tee-1 branch June 19, 2026 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tee: Are fn tee()'s errors completely discarded?

2 participants