Fix pr -o/--indent overflow handling#12974
Merged
cakebaker merged 1 commit intoJun 19, 2026
Merged
Conversation
Parse the indent margin as i32 to match GNU pr's behavior. Add test cases as well.
|
GNU testsuite comparison: |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12764
Parse the indent margin as i32 (matching GNU pr's behavior) instead of usize. Offsets larger than i32::MAX now fail with
'-o MARGIN' invalid line offset: <val>: Value too large for defined data typeinstead of attempting a hugeallocation. Negative and non-numeric values exit with code 1 and a clear invalid line offset message. Adds tests covering too-large, negative, and non-numeric offsets.