pr: stream -o/--indent offset to avoid abort on large values#12994
Open
TheAdamWarlock wants to merge 1 commit into
Open
pr: stream -o/--indent offset to avoid abort on large values#12994TheAdamWarlock wants to merge 1 commit into
TheAdamWarlock wants to merge 1 commit into
Conversation
Store the indent as a count and stream the spaces at print time instead of allocating an N-byte string up front. Added regression test as well.
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12978.
pr -o N(--indent) aborted on large offsets that fit in i32 (e.g.-o 999999999) because the indent was built as" ".repeat(n), allocating an N-byte string up front that fails under limited memory. The change stores the offset as a count and streams the spaces in 256-byte chunks at print time, so peak memory is constant and output is unchanged. Adds a regression test that runsprwith a large offset under a small memory cap and checks it exits cleanly.