sort: add locale-aware month parsing using ICU by ChrisDryden · Pull Request #9722 · uutils/coreutils

ChrisDryden · 2025-12-19T16:53:46Z

This PR is to address the lack of locale information when using the -M option in sort since all of the months were hardcoded to the english months. This PR introduces a new dependency icu_datetime to be able to get all of the month locale information.

Originally when trying to fix the associated GNU test it wasn't working because nl was removing non-utf8 characters. Now that the nl issue was addressed this should fix that GNU test.

When implementing this, choices were made that were maybe not the most efficient, but more readable and I think thats the better choice for this type of solution because there will only be a maximum of 12 comparisons when implementing this type of sorting.

ChrisDryden · 2025-12-19T17:15:39Z

Going to have to wait and rebase until this PR is in: #9720

sylvestre · 2025-12-19T17:40:33Z

i will have a look once the jobs are green but the approach looks perfect!

ChrisDryden · 2025-12-19T22:10:22Z

Had to revert the string lossy change and add a comment, the string lossy modifies the non utf characters

github-actions · 2025-12-19T22:28:33Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

ChrisDryden · 2025-12-19T23:28:34Z

I think another one of the utilities is lossy converting the non utf, investigating now

ChrisDryden · 2025-12-19T23:33:42Z

Oh the CI is missing the Japan locale

ChrisDryden · 2025-12-19T23:49:32Z

It passed! it was the Japanese locale missing causing the failure

github-actions · 2025-12-19T23:52:33Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-month is no longer failing!
Congrats! The gnu test tests/tail/inotify-dir-recreate is now passing!

RenjiSann · 2025-12-21T02:03:13Z

Look really good ! Thank you for taking over the month sorting :D

One thing we should be mindful of is the fact that GNU's month sorting exclusively matches month names against the abbreviated month name (see this discussion I had with ICU guys), so it's not bothering with trimming.

Now, this may be a limitation of GNU, and we might not want to stick with it

ChrisDryden · 2025-12-24T04:32:34Z

Sounds like the ICU data abbreviations don't always match the GNU abbreviations, the one specifically that would fail this is the french april. I don't see how we could do this without the non-exclusive matching

ChrisDryden · 2026-01-05T18:15:09Z

@RenjiSann is there a different pathway we should take for this then? Was wondering if you had any thoughts on what the next steps should be?

github-actions · 2026-01-05T18:50:23Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-month is no longer failing!

RenjiSann · 2026-01-05T21:05:25Z

I assumed that would be a known incompatibility, since I can't come with a better solution

sylvestre · 2026-01-09T20:37:00Z

could you please fix the conflicts ? :)

github-actions · 2026-01-09T20:54:48Z

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/sort/sort-month is no longer failing!

sylvestre · 2026-01-09T21:05:18Z

fails with:


error[E0425]: cannot find function `sem_init` in crate `nix::libc`
    --> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/ctrlc-3.5.1/src/platform/unix/mod.rs:19:20
     |
  19 |         nix::libc::sem_init(&mut SEMAPHORE as *mut _, SEM_THREAD_SHARED, 0);
     |                    ^^^^^^^^ help: a function with a similar name exists: `res_init`
     |
    ::: /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/libc-0.2.180/src/unix/mod.rs:1449:5
     |
1449 |     pub fn res_init() -> c_int;
     |     --------------------------- similarly named function `res_init` defined here

For more information about this error, try `rustc --explain E0425`.
error: could not compile `ctrlc` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

ChrisDryden · 2026-01-09T23:04:26Z

Looks like I updated that dependency when running cargo update and that ctrlc version breaks redox, I fixed it to the same version as upstream

github-actions · 2026-01-09T23:13:09Z

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/sort/sort-month is no longer failing!

github-actions · 2026-01-10T09:05:09Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-month is no longer failing!

sylvestre · 2026-01-10T09:11:39Z

cargo deny fails
(just add an ignore)

github-actions · 2026-01-14T00:54:17Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/sort/sort-month is no longer failing!

sylvestre · 2026-01-18T12:54:38Z

sorry, it needs rebasing

github-actions · 2026-01-20T18:58:00Z

GNU testsuite comparison:

GNU test failed: tests/sort/sort-debug-keys. tests/sort/sort-debug-keys is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/sort/sort-month is no longer failing!

ChrisDryden · 2026-01-20T18:59:05Z

Whoops looks like something went wrong in the rebase

codspeed-hq · 2026-01-20T19:16:56Z

Merging this PR will not alter performance

✅ 283 untouched benchmarks
⏩ 38 skipped benchmarks¹

_{Comparing ChrisDryden:sort-locale-month (8fa6212) with main (7b0e7e4)}

38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2026-01-21T11:47:15Z

GNU testsuite comparison:

GNU test failed: tests/sort/sort-debug-keys. tests/sort/sort-debug-keys is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/sort/sort-month is no longer failing!

github-actions · 2026-01-26T17:42:36Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-month is no longer failing!

ChrisDryden · 2026-02-02T14:01:33Z

Amazing to think that this is the last sort gnu test, will work on rebasing this today

ChrisDryden · 2026-02-03T14:24:39Z

The sort-months gnu test didnt put the comment during the outage but its still passing.

github-actions · 2026-02-03T22:42:10Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/follow-name (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/sort/sort-month is no longer failing!

github-actions · 2026-02-10T04:30:06Z

GNU testsuite comparison:

Congrats! The gnu test tests/pr/bounded-memory is no longer failing!
Congrats! The gnu test tests/sort/sort-month is no longer failing!
Note: The gnu test tests/expand/bounded-memory is now being skipped but was previously passing.

ChrisDryden mentioned this pull request Dec 19, 2025

locale.rs: move more code outside of the unsafe block #9720

Merged

ChrisDryden force-pushed the sort-locale-month branch 2 times, most recently from 3b395de to 0754860 Compare December 19, 2025 17:12

This was referenced Dec 19, 2025

sort -M Locale Month Parsing Gap #9715

Open

sort -k doesn't handle locale #3123

Open

sylvestre force-pushed the sort-locale-month branch from 0754860 to 0d9897b Compare December 19, 2025 21:09

ChrisDryden force-pushed the sort-locale-month branch from 0d9897b to 0635270 Compare December 19, 2025 21:30

sylvestre reviewed Dec 19, 2025

View reviewed changes

Comment thread src/uucore/src/lib/features/i18n/month.rs

sylvestre reviewed Dec 19, 2025

View reviewed changes

Comment thread src/uucore/src/lib/features/i18n/month.rs

ChrisDryden force-pushed the sort-locale-month branch 3 times, most recently from f6801e0 to efae246 Compare December 19, 2025 22:09

ChrisDryden force-pushed the sort-locale-month branch from efae246 to 626314f Compare December 19, 2025 22:11

ChrisDryden mentioned this pull request Dec 19, 2025

GNU coreutils 9.9: Test report #9127

Closed

ChrisDryden mentioned this pull request Dec 19, 2025

GNU coreutils 9.9: Detailed Test report 12/19 #9729

Closed

ChrisDryden marked this pull request as ready for review December 19, 2025 23:37

ChrisDryden force-pushed the sort-locale-month branch from 5182e80 to 097f5b4 Compare January 9, 2026 20:40

ChrisDryden mentioned this pull request Jan 20, 2026

GNU coreutils 9.9: Detailed Test report 01/20 #10390

Closed

ChrisDryden force-pushed the sort-locale-month branch from a3143ce to 27f23be Compare January 20, 2026 18:37

ChrisDryden force-pushed the sort-locale-month branch 3 times, most recently from 50eb22b to 63aec75 Compare January 26, 2026 17:07

ChrisDryden force-pushed the sort-locale-month branch from c900759 to c556ee0 Compare February 2, 2026 23:06

ChrisDryden added 4 commits February 10, 2026 04:05

sort: add locale-aware month parsing using ICU

c9dfc90

CI: add ja_JP.UTF-8 locale for sort-month test

88c5e38

deny.toml: skip hashbrown 0.15.5 duplicate

2b618a2

sort: fix month parsing for C/POSIX locale

8fa6212

ChrisDryden force-pushed the sort-locale-month branch from 85627b7 to 8fa6212 Compare February 10, 2026 04:05

Uh oh!

Conversation

ChrisDryden commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChrisDryden commented Dec 19, 2025

Uh oh!

sylvestre commented Dec 19, 2025

Uh oh!

Uh oh!

Uh oh!

ChrisDryden commented Dec 19, 2025

Uh oh!

github-actions Bot commented Dec 19, 2025

Uh oh!

ChrisDryden commented Dec 19, 2025

Uh oh!

ChrisDryden commented Dec 19, 2025

Uh oh!

ChrisDryden commented Dec 19, 2025

Uh oh!

github-actions Bot commented Dec 19, 2025

Uh oh!

RenjiSann commented Dec 21, 2025

Uh oh!

ChrisDryden commented Dec 24, 2025

Uh oh!

ChrisDryden commented Jan 5, 2026

Uh oh!

github-actions Bot commented Jan 5, 2026

Uh oh!

RenjiSann commented Jan 5, 2026

Uh oh!

sylvestre commented Jan 9, 2026

Uh oh!

github-actions Bot commented Jan 9, 2026

Uh oh!

sylvestre commented Jan 9, 2026

Uh oh!

ChrisDryden commented Jan 9, 2026

Uh oh!

github-actions Bot commented Jan 9, 2026

Uh oh!

github-actions Bot commented Jan 10, 2026

Uh oh!

sylvestre commented Jan 10, 2026

Uh oh!

github-actions Bot commented Jan 14, 2026

Uh oh!

sylvestre commented Jan 18, 2026

Uh oh!

github-actions Bot commented Jan 20, 2026

Uh oh!

ChrisDryden commented Jan 20, 2026

Uh oh!

codspeed-hq Bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

github-actions Bot commented Jan 21, 2026

Uh oh!

github-actions Bot commented Jan 26, 2026

Uh oh!

ChrisDryden commented Feb 2, 2026

Uh oh!

ChrisDryden commented Feb 3, 2026

Uh oh!

github-actions Bot commented Feb 3, 2026

Uh oh!

github-actions Bot commented Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ChrisDryden commented Dec 19, 2025 •

edited

Loading

codspeed-hq Bot commented Jan 20, 2026 •

edited

Loading