ocl, ze: remove error messages for destroy calls from a wrapper#5340
Open
dzarukin wants to merge 2 commits into
Open
ocl, ze: remove error messages for destroy calls from a wrapper#5340dzarukin wants to merge 2 commits into
dzarukin wants to merge 2 commits into
Conversation
Contributor
Author
|
make test |
rjoursler
approved these changes
Jun 16, 2026
This is done to have an ability to disable warnings for destruction API under wrapper_t.
01efc69 to
02540cb
Compare
echeresh
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.devtools.intel.com/browse/MFDNN-15099
https://jira.devtools.intel.com/browse/MFDNN-15133
For OpenCL v3.1 the library will de-initialize all its objects before global static objects when the application finishes.
This affects the way our primitive/kernel cache works and all calls to destroy objects become invalid and start spamming tons of messages.
It looks like there's nothing critical happening with not destroying those objects ahead of time. Thus, the decision is to simply ignore the specific message when destroying objects that get populated in the cache, including objects the library manages itself.
The clean alternative to this approach is to reset cache by setting its capacity to 0 but this new requirement will transitively be put on ALL applications with oneDNN integration, which is a huge impact and doesn't seem like a user-friendly option.
Currently, Infra filters out these messages. Once this PR lands, those filters will be reverted, too.
Standalone CI with filters disabled