Skip to content

Create disableMultipart option in FileUploader#224

Merged
valorkin merged 2 commits intovalor-software:developmentfrom
tdonohue:streaming_upload_support
Jun 21, 2016
Merged

Create disableMultipart option in FileUploader#224
valorkin merged 2 commits intovalor-software:developmentfrom
tdonohue:streaming_upload_support

Conversation

@tdonohue
Copy link
Copy Markdown
Contributor

Proposed fix for #223 , based on this PR to angular-file-upload: nervgh/angular-file-upload#602

Allows you to optionally tell FileUploader to stream the file instead of using a multipart form.

Typescript usage example:

public uploader:FileUploader = new FileUploader({url: URL, disableMultipart: true});

@valorkin
Copy link
Copy Markdown
Member

valorkin commented Jun 6, 2016

Looks really good for me!

@valorkin
Copy link
Copy Markdown
Member

valorkin commented Jun 6, 2016

@tdonohue can you please add documentation update, so other devs can find it?

@tdonohue
Copy link
Copy Markdown
Contributor Author

tdonohue commented Jun 6, 2016

@valorkin : Done! I added basic info for this new disableMultipart parameter alongside the docs for url and authToken in the readme docs

@langfors
Copy link
Copy Markdown

@valorkin please merge!

@valorkin
Copy link
Copy Markdown
Member

Looks great! Thanks a lot!

@valorkin valorkin merged commit 22307d2 into valor-software:development Jun 21, 2016
@tdonohue tdonohue deleted the streaming_upload_support branch June 21, 2016 15:09
@ihadeed
Copy link
Copy Markdown

ihadeed commented Jun 22, 2016

@tdonohue thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants