Skip to content

Added onFileDrop() event to documentation#857

Merged
adrianfaciu merged 1 commit intovalor-software:developmentfrom
joshterrill:development
Oct 2, 2017
Merged

Added onFileDrop() event to documentation#857
adrianfaciu merged 1 commit intovalor-software:developmentfrom
joshterrill:development

Conversation

@joshterrill
Copy link
Copy Markdown
Contributor

In case anyone wants to use the onFileDrop event to handle the files in their own way, I've added it to the documentation. I ran into a situation where I wanted to add some custom logic around file uploading, so I added onFileDrop() to my element in order to grab the list of files.

In case anyone wants to use the onFileDrop event to handle the files in their own way, I've added it to the documentation.
@adrianfaciu adrianfaciu merged commit 7fc4945 into valor-software:development Oct 2, 2017
@adrianfaciu
Copy link
Copy Markdown

Thanks for this contribution. We're working to get this into a better shape. If you have any other contributions they will be welcomed 😉

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 2, 2017

Codecov Report

Merging #857 into development will increase coverage by 3.24%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #857      +/-   ##
===============================================
+ Coverage        32.22%   35.47%   +3.24%     
===============================================
  Files               10       10              
  Lines              540      530      -10     
  Branches            70       74       +4     
===============================================
+ Hits               174      188      +14     
+ Misses             363      325      -38     
- Partials             3       17      +14
Impacted Files Coverage Δ
scripts/matchers.ts 33.33% <0%> (-9.53%) ⬇️
src/file-upload/file-like-object.class.ts 23.52% <0%> (-8.05%) ⬇️
src/file-upload/file-item.class.ts 21.42% <0%> (-0.8%) ⬇️
src/file-upload/file-uploader.class.ts 25% <0%> (-0.19%) ⬇️
src/file-upload/file-drop.directive.ts 61.22% <0%> (+28.57%) ⬆️
src/file-upload/file-select.directive.ts 80% <0%> (+30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41759be...28d98bc. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants