GH-653: Fix sensitive data logging, etc#497
Conversation
…y in inbox & SSE mappers - Downgrade inbox message logging from INFO to DEBUG without payload - Add WARN-level logging to ValtimoCloudEventMapper catch blocks - Replace non-null assertion with null-safe check in DocumentSseEventMapper - Return null instead of empty string for missing caseDefinitionVersionTag Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… in RabbitMessagePublisher - Fix debug log that printed exchange instead of routingKey - Replace non-null assertion with proper null handling for confirmation result - Use idiomatic ?.let for returned message check - Remove stray escaped quotes from exception messages Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis pull request improves null-safety and error handling across multiple components. Event mappers now treat previously defaulted fields (like ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
backend/outbox/outbox-rabbitmq/src/main/kotlin/com/ritense/outbox/rabbitmq/RabbitMessagePublisher.kt (1)
65-66: Disambiguate duplicateroutingKeyfields in the exception message.Line 66 includes two
routingKey=entries (returned.routingKeyand configuredroutingKey), which can confuse troubleshooting. Consider distinct labels (returnedRoutingKey/configuredRoutingKey).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b091b349-d206-4a42-b7d1-754e737666a4
📒 Files selected for processing (8)
backend/case/src/main/kotlin/com/ritense/case/mapper/ConfigurationIssueSseEventMapper.ktbackend/case/src/main/kotlin/com/ritense/document/mapper/DocumentSseEventMapper.ktbackend/case/src/test/kotlin/com/ritense/case/mapper/ConfigurationIssueSseEventMapperTest.ktbackend/case/src/test/kotlin/com/ritense/document/mapper/DocumentSseEventMapperTest.ktbackend/inbox/src/main/kotlin/com/ritense/inbox/InboxHandlingService.ktbackend/inbox/src/main/kotlin/com/ritense/inbox/ValtimoCloudEventMapper.ktbackend/outbox/outbox-rabbitmq/src/main/kotlin/com/ritense/outbox/rabbitmq/RabbitMessagePublisher.ktdocumentation/release-notes/13.x.x/13.22.0/README.md
generiekzaakafhandelcomponent/gzac-issues#653
ValtimoCloudEventMappercatch blocks (without sensitive data)resultId!!with null-safe check inDocumentSseEventMapperto prevent NPEcaseDefinitionVersionTaginConfigurationIssueSseEventMapper