Skip to content

Removed sensitive information from exceptions#599

Merged
ivo-ritense merged 3 commits into
next-minorfrom
story/657-remove-sensitive-information
Apr 24, 2026
Merged

Removed sensitive information from exceptions#599
ivo-ritense merged 3 commits into
next-minorfrom
story/657-remove-sensitive-information

Conversation

@ivo-ritense

Copy link
Copy Markdown
Collaborator

No description provided.

@ivo-ritense ivo-ritense requested review from a team as code owners April 24, 2026 09:35
@coderabbitai

coderabbitai Bot commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@ivo-ritense has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 50 minutes and 11 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 50 minutes and 11 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 204719e5-46ad-47d7-bc31-8f7419e7dced

📥 Commits

Reviewing files that changed from the base of the PR and between 827a45b and e3b9523.

📒 Files selected for processing (2)
  • backend/app/gzac/src/main/resources/logback-spring.xml
  • backend/web/src/main/kotlin/com/ritense/valtimo/web/logging/LoggingRestClientCustomizer.kt
📝 Walkthrough

Walkthrough

This pull request modifies the error-handling behavior of LoggingRestClientCustomizer to change what information is included in thrown HttpClientErrorException instances. The exception now contains only HTTP status code and status text, while detailed request/response information (headers, body, charset details) is logged via logger.debug() instead. Corresponding developer documentation is added explaining the DEBUG-level logging configuration options, and release notes are updated to document this security-focused change.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch story/657-remove-sensitive-information

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3175640e-3787-4039-bd6f-b67b3950f085

📥 Commits

Reviewing files that changed from the base of the PR and between 943ee96 and 827a45b.

📒 Files selected for processing (3)
  • backend/web/src/main/kotlin/com/ritense/valtimo/web/logging/LoggingRestClientCustomizer.kt
  • documentation/features/logging/for-developers.md
  • documentation/release-notes/13.x.x/13.26.0/README.md

@ivo-ritense ivo-ritense merged commit 96140f3 into next-minor Apr 24, 2026
5 checks passed
@ivo-ritense ivo-ritense deleted the story/657-remove-sensitive-information branch April 24, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants