Make agent-browser errors doc more descriptive#190
Merged
Conversation
Contributor
|
@shpeedle is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
Nice, thank you! |
timothywangdev
pushed a commit
to timothywangdev/banana-browser
that referenced
this pull request
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs: clarify distinction between
consoleanderrorscommandsProblem
The documentation for the
consoleanderrorscommands was unclear about what each command captures. Users expectederrorsto show all errors includingconsole.error()calls, but it only shows uncaught JavaScript exceptions.This caused confusion when users would see errors in
agent-browser consoleoutput but get empty results fromagent-browser errors.Solution
Updated the documentation in
README.mdto clarify:console- captures allconsole.*calls (log, error, warn, info)errors- captures only uncaught JavaScript exceptions (notconsole.error()calls)Future Enhancement Suggestion
A useful follow-up feature would be adding type filtering to the
consolecommand:This would make it easier to filter for specific message types without parsing the full output.