Fix Chrome extensions not loading by forcing headed mode when extensions present#652
Merged
Conversation
…ons present Fixes #640
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Restore the ChromeProcess::wait_or_kill() method that was accidentally removed. It is still referenced by BrowserProcess in browser.rs and is needed for graceful shutdown / cookie persistence (PR #650). Add unit tests verifying --headless=new is omitted when extensions are present. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…nel option - Skip --window-size=1280,720 when extensions force headed mode (native) - Remove unexplained channel: 'chromium' from extensions launch path (TS) - Add window-size assertion to existing extension test Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Mar 8, 2026
Merged
leeguooooo
pushed a commit
to leeguooooo/chrome-use
that referenced
this pull request
Mar 9, 2026
…ons present (vercel-labs#652) * Fix Chrome extensions not loading by forcing headed mode when extensions present Fixes vercel-labs#640 * Restore wait_or_kill() and add tests for headless+extensions logic Restore the ChromeProcess::wait_or_kill() method that was accidentally removed. It is still referenced by BrowserProcess in browser.rs and is needed for graceful shutdown / cookie persistence (PR vercel-labs#650). Add unit tests verifying --headless=new is omitted when extensions are present. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Fix window-size leak in headed+extensions mode and remove unused channel option - Skip --window-size=1280,720 when extensions force headed mode (native) - Remove unexplained channel: 'chromium' from extensions launch path (TS) - Add window-size assertion to existing extension test Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: ctate <366502+ctate@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> (cherry picked from commit 68cebe5)
timothywangdev
pushed a commit
to timothywangdev/banana-browser
that referenced
this pull request
Mar 17, 2026
…ons present (vercel-labs#652) * Fix Chrome extensions not loading by forcing headed mode when extensions present Fixes vercel-labs#640 * Restore wait_or_kill() and add tests for headless+extensions logic Restore the ChromeProcess::wait_or_kill() method that was accidentally removed. It is still referenced by BrowserProcess in browser.rs and is needed for graceful shutdown / cookie persistence (PR vercel-labs#650). Add unit tests verifying --headless=new is omitted when extensions are present. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Fix window-size leak in headed+extensions mode and remove unused channel option - Skip --window-size=1280,720 when extensions force headed mode (native) - Remove unexplained channel: 'chromium' from extensions launch path (TS) - Add window-size assertion to existing extension test Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: ctate <366502+ctate@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
ctate
added a commit
that referenced
this pull request
Apr 12, 2026
The skills CLI metadata.internal flag was never implemented (PRs #587 and #652 were both closed). All 6 skills were showing in the installer. Move the 5 specialized skills (dogfood, electron, slack, vercel-sandbox, agentcore) from skills/ to skill-data/, which the skills CLI does not search. The bootstrap skill stays in skills/ for discovery. The Rust CLI searches both directories so agent-browser skills list/get still serves all 6.
ctate
added a commit
that referenced
this pull request
Apr 12, 2026
…ne (#1227) The skills CLI metadata.internal flag was never implemented (PRs #587 and #652 were both closed). All 6 skills were showing in the installer. Move the 5 specialized skills (dogfood, electron, slack, vercel-sandbox, agentcore) from skills/ to skill-data/, which the skills CLI does not search. The bootstrap skill stays in skills/ for discovery. The Rust CLI searches both directories so agent-browser skills list/get still serves all 6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #640