Quality: Crash on malformed __NCC_OPTS env var in typescript loader#1313
Closed
LucciHank wants to merge 1 commit intovercel:mainfrom
Closed
Conversation
…escript loader
JSON.parse(process.env.__NCC_OPTS || '{}') throws SyntaxError on invalid JSON; destructuring then throws TypeError if the result is not an object (e.g. env var set to a string or number). This crashes the entire ncc process whenever TypeScript support is used.
Affected files: typescript.js
Signed-off-by: Hoangg Anh <131897682+LucciHank@users.noreply.github.com>
Author
Auto-closed: CI checks failedThe following checks failed: lint Closing this PR since required CI checks did not pass. Sorry for the inconvenience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
JSON.parse(process.env.__NCC_OPTS || '{}') throws SyntaxError on invalid JSON; destructuring then throws TypeError if the result is not an object (e.g. env var set to a string or number). This crashes the entire ncc process whenever TypeScript support is used.
Changes
src/typescript.js(modified)Type of Change
Testing
Severity:
medium