Skip to content

revalidate APIs should make route handlers dynamic#58466

Merged
timneutkens merged 5 commits intocanaryfrom
fix/revalidate-dynamic
Nov 16, 2023
Merged

revalidate APIs should make route handlers dynamic#58466
timneutkens merged 5 commits intocanaryfrom
fix/revalidate-dynamic

Conversation

@ztanner
Copy link
Copy Markdown
Member

@ztanner ztanner commented Nov 15, 2023

What?

Using revalidateTag or revalidatePath in a route handler will not currently opt the handler into dynamic behavior. This means that if you use these APIs and don't opt into dynamic behavior by some other means, the revalidation call won't do anything as the route handler will be served statically.

Why?

During static generation, we do not currently indicate that usage of these APIs should opt into dynamic usage.

How?

This updates revalidateTag to throw a DynamicUsageError (similar to our other scenarios, such as search params bailout, headers/cookies, or fetch + revalidate/no-store)

Closes NEXT-1712

@ijjk
Copy link
Copy Markdown
Member

ijjk commented Nov 15, 2023

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix/revalidate-dynamic Change
buildDuration 10.7s 10.7s N/A
buildDurationCached 6.1s 6.7s ⚠️ +606ms
nodeModulesSize 199 MB 199 MB ⚠️ +1.68 kB
nextStartRea..uration (ms) 419ms 427ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix/revalidate-dynamic Change
199-HASH.js gzip 29.2 kB 29.2 kB N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB N/A
494.HASH.js gzip 180 B 181 B N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 240 B 238 B N/A
main-HASH.js gzip 31.7 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 46.9 kB 46.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/revalidate-dynamic Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix/revalidate-dynamic Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 504 B 506 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB
edge-ssr-HASH.js gzip 253 B 255 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.3 kB 4.3 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.65 kB 2.65 kB N/A
routerDirect..HASH.js gzip 311 B 311 B
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.17 kB 3.17 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix/revalidate-dynamic Change
_buildManifest.js gzip 486 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/revalidate-dynamic Change
index.html gzip 528 B 526 B N/A
link.html gzip 541 B 541 B
withRouter.html gzip 524 B 522 B N/A
Overall change 541 B 541 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js fix/revalidate-dynamic Change
edge-ssr.js gzip 92.6 kB 92.6 kB N/A
page.js gzip 145 kB 145 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js fix/revalidate-dynamic Change
middleware-b..fest.js gzip 625 B 625 B
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 24.8 kB 24.8 kB
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 27.4 kB 27.4 kB
Next Runtimes
vercel/next.js canary vercel/next.js fix/revalidate-dynamic Change
app-page-exp...dev.js gzip 167 kB 167 kB
app-page-exp..prod.js gzip 93.2 kB 93.2 kB
app-page-tur..prod.js gzip 93.9 kB 93.9 kB
app-page-tur..prod.js gzip 88.5 kB 88.5 kB
app-page.run...dev.js gzip 137 kB 137 kB
app-page.run..prod.js gzip 87.9 kB 87.9 kB
app-route-ex...dev.js gzip 23.8 kB 23.8 kB
app-route-ex..prod.js gzip 16.4 kB 16.4 kB
app-route-tu..prod.js gzip 16.4 kB 16.4 kB
app-route-tu..prod.js gzip 16 kB 16 kB
app-route.ru...dev.js gzip 23.2 kB 23.2 kB
app-route.ru..prod.js gzip 16 kB 16 kB
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB
pages-turbo...prod.js gzip 21.8 kB 21.8 kB
pages.runtim...dev.js gzip 22.5 kB 22.5 kB
pages.runtim..prod.js gzip 21.8 kB 21.8 kB
server.runti..prod.js gzip 49 kB 49 kB
Overall change 923 kB 923 kB
Commit: 79ff677

@ijjk
Copy link
Copy Markdown
Member

ijjk commented Nov 15, 2023

Tests Passed

@ztanner ztanner marked this pull request as ready for review November 15, 2023 04:46
Comment thread packages/next/src/server/web/spec-extension/revalidate-tag.ts Outdated
@ztanner ztanner requested a review from timneutkens November 15, 2023 15:35
@timneutkens timneutkens merged commit 8d4f4fc into canary Nov 16, 2023
@timneutkens timneutkens deleted the fix/revalidate-dynamic branch November 16, 2023 10:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants