Skip to content

Update React from 6c3b8dbfe to a4939017f#63413

Closed
ztanner wants to merge 4 commits intocanaryfrom
zt/upgrade-react
Closed

Update React from 6c3b8dbfe to a4939017f#63413
ztanner wants to merge 4 commits intocanaryfrom
zt/upgrade-react

Conversation

@ztanner
Copy link
Copy Markdown
Contributor

@ztanner ztanner commented Mar 18, 2024 •
edited
Loading

No description provided.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Mar 18, 2024
@ijjk
Copy link
Copy Markdown
Member

ijjk commented Mar 18, 2024 •
edited
Loading

Failing test suites

Commit: c8afb6e

pnpm test-dev test/e2e/app-dir/rsc-basic/rsc-basic.test.ts (PPR)

  • app dir - rsc basics > should not use bundled react for pages with app
  • app dir - rsc basics > should use canary react for app
  • app dir - rsc basics > should be able to call legacy react-dom/server APIs in client components
  • app dir - rsc basics > react@experimental > should opt into the react@experimental when enabling ppr
  • app dir - rsc basics > react@experimental > should opt into the react@experimental when enabling taint
Expand output

● app dir - rsc basics › should not use bundled react for pages with app

expect(received).toMatch(expected)

Expected substring: "-experimental-"
Received string:    ""

  494 |
  495 |       ssrAppReactVersions.forEach((version) =>
> 496 |         expect(version).toMatch(bundledReactVersionPattern)
      |                         ^
  497 |       )
  498 |
  499 |       const browser = await next.browser('/pages-react')

  at toMatch (e2e/app-dir/rsc-basic/rsc-basic.test.ts:496:25)
      at Array.forEach (<anonymous>)
  at Object.forEach (e2e/app-dir/rsc-basic/rsc-basic.test.ts:495:27)

● app dir - rsc basics › should use canary react for app

expect(received).toMatch(expected)

Expected substring: "-experimental-"
Received string:    ""

  535 |
  536 |       ssrPagesReactVersions.forEach((version) => {
> 537 |         expect(version).toMatch(bundledReactVersionPattern)
      |                         ^
  538 |       })
  539 |
  540 |       const browser = await next.browser('/app-react')

  at toMatch (e2e/app-dir/rsc-basic/rsc-basic.test.ts:537:25)
      at Array.forEach (<anonymous>)
  at Object.forEach (e2e/app-dir/rsc-basic/rsc-basic.test.ts:536:29)

● app dir - rsc basics › should be able to call legacy react-dom/server APIs in client components

expect(received).toBe(expected) // Object.is equality

Expected: "<div class=\"react-static-markup\">React Static Markup</div>"
Received: ""

  557 |       const $ = await next.render$('/app-react')
  558 |       const content = $('#markup').text()
> 559 |       expect(content).toBe(
      |                       ^
  560 |         '<div class="react-static-markup">React Static Markup</div>'
  561 |       )
  562 |

  at Object.toBe (e2e/app-dir/rsc-basic/rsc-basic.test.ts:559:23)

● app dir - rsc basics › react@experimental › should opt into the react@experimental when enabling ppr

expect(received).toMatch(expected)

Expected substring: "-experimental-"
Received string:    ""

  668 |
  669 |           ssrPagesReactVersions.forEach((version) => {
> 670 |             expect(version).toMatch('-experimental-')
      |                             ^
  671 |           })
  672 |
  673 |           const browser = await next.browser('/app-react')

  at toMatch (e2e/app-dir/rsc-basic/rsc-basic.test.ts:670:29)
      at Array.forEach (<anonymous>)
  at forEach (e2e/app-dir/rsc-basic/rsc-basic.test.ts:669:33)

● app dir - rsc basics › react@experimental › should opt into the react@experimental when enabling taint

expect(received).toMatch(expected)

Expected substring: "-experimental-"
Received string:    ""

  668 |
  669 |           ssrPagesReactVersions.forEach((version) => {
> 670 |             expect(version).toMatch('-experimental-')
      |                             ^
  671 |           })
  672 |
  673 |           const browser = await next.browser('/app-react')

  at toMatch (e2e/app-dir/rsc-basic/rsc-basic.test.ts:670:29)
      at Array.forEach (<anonymous>)
  at forEach (e2e/app-dir/rsc-basic/rsc-basic.test.ts:669:33)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/development/acceptance-app/ReactRefreshLogBox.test.ts

  • ReactRefreshLogBox app default > boundaries
Expand output

● ReactRefreshLogBox app default › boundaries

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('[data-nextjs-toast]')

  421 |     return this.chain(() => {
  422 |       return page
> 423 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  424 |         .then(async (el) => {
  425 |           // it seems selenium waits longer and tests rely on this behavior
  426 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:423:10)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Copy Markdown
Member

ijjk commented Mar 18, 2024 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js zt/upgrade-react Change
buildDuration 14.6s 14.7s N/A
buildDurationCached 8s 6.8s N/A
nodeModulesSize 198 MB 199 MB ⚠️ +532 kB
nextStartRea..uration (ms) 416ms 413ms N/A
Client Bundles (main, webpack) Overall increase ⚠️
vercel/next.js canary vercel/next.js zt/upgrade-react Change
2453-HASH.js gzip 31 kB 31.3 kB ⚠️ +318 B
3304.HASH.js gzip 181 B 181 B ✓
3f784ff6-HASH.js gzip 53.7 kB 53.5 kB N/A
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 242 B 243 B N/A
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 76.4 kB 76.7 kB ⚠️ +318 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js zt/upgrade-react Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js zt/upgrade-react Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B ✓
amp-HASH.js gzip 505 B 505 B ✓
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B ✓
head-HASH.js gzip 352 B 352 B ✓
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB ✓
index-HASH.js gzip 259 B 259 B ✓
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 6.57 kB 6.57 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js zt/upgrade-react Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js zt/upgrade-react Change
index.html gzip 529 B 528 B N/A
link.html gzip 541 B 541 B ✓
withRouter.html gzip 524 B 524 B ✓
Overall change 1.06 kB 1.06 kB ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js zt/upgrade-react Change
edge-ssr.js gzip 95.3 kB 95.3 kB N/A
page.js gzip 3.04 kB 3.04 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js zt/upgrade-react Change
middleware-b..fest.js gzip 625 B 622 B N/A
middleware-r..fest.js gzip 151 B 151 B ✓
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B ✓
Overall change 990 B 990 B ✓
Next Runtimes Overall increase ⚠️
vercel/next.js canary vercel/next.js zt/upgrade-react Change
app-page-exp...dev.js gzip 170 kB 170 kB ⚠️ +120 B
app-page-exp..prod.js gzip 97 kB 97.7 kB ⚠️ +726 B
app-page-tur..prod.js gzip 98.7 kB 99.2 kB ⚠️ +455 B
app-page-tur..prod.js gzip 93 kB 93.5 kB ⚠️ +559 B
app-page.run...dev.js gzip 144 kB 156 kB ⚠️ +11.9 kB
app-page.run..prod.js gzip 91.5 kB 92.3 kB ⚠️ +789 B
app-route-ex...dev.js gzip 21.4 kB 21.2 kB N/A
app-route-ex..prod.js gzip 15.1 kB 15.1 kB N/A
app-route-tu..prod.js gzip 15.1 kB 15.1 kB N/A
app-route-tu..prod.js gzip 14.8 kB 14.8 kB ✓
app-route.ru...dev.js gzip 21 kB 21 kB N/A
app-route.ru..prod.js gzip 14.8 kB 14.8 kB ✓
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB ✓
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB ✓
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB ✓
pages-turbo...prod.js gzip 22.5 kB 22.5 kB ✓
pages.runtim...dev.js gzip 23.1 kB 23.1 kB ✓
pages.runtim..prod.js gzip 22.4 kB 22.4 kB ✓
server.runti..prod.js gzip 51 kB 51 kB ✓
Overall change 872 kB 886 kB ⚠️ +14.6 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js zt/upgrade-react Change
0.pack gzip 1.57 MB 1.57 MB ⚠️ +1.25 kB
index.pack gzip 106 kB 106 kB ⚠️ +298 B
Overall change 1.68 MB 1.68 MB ⚠️ +1.54 kB
Diff details
Diff for middleware.js

Diff too large to display

Diff for 2453-HASH.js

Diff too large to display

Diff for 3f784ff6-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js 
failed to diff
Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js 
failed to diff
Diff for app-page.runtime.prod.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Commit: c8afb6e

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Mar 18, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/react-dom@0.0.0-experimental-a4939017f-20240320 environment +1 17.3 MB react-bot
npm/react-dom@18.3.0-canary-a4939017f-20240320 environment +1 14 MB react-bot
npm/react-server-dom-turbopack@0.0.0-experimental-a4939017f-20240320 None +1 2.56 MB react-bot
npm/react-server-dom-turbopack@18.3.0-canary-a4939017f-20240320 None +1 2.3 MB react-bot
npm/react-server-dom-webpack@0.0.0-experimental-a4939017f-20240320 None +1 2.61 MB react-bot
npm/react-server-dom-webpack@18.3.0-canary-a4939017f-20240320 None +1 2.35 MB react-bot
npm/react@0.0.0-experimental-a4939017f-20240320 environment 0 638 kB react-bot
npm/react@18.3.0-canary-a4939017f-20240320 environment 0 601 kB react-bot

🚮 Removed packages: npm/react-dom@0.0.0-experimental-14898b6a9-20240318, npm/react-dom@18.3.0-canary-14898b6a9-20240318, npm/react-server-dom-turbopack@0.0.0-experimental-14898b6a9-20240318, npm/react-server-dom-turbopack@18.3.0-canary-14898b6a9-20240318, npm/react-server-dom-webpack@0.0.0-experimental-14898b6a9-20240318, npm/react-server-dom-webpack@18.3.0-canary-14898b6a9-20240318, npm/react@0.0.0-experimental-14898b6a9-20240318, npm/react@18.3.0-canary-14898b6a9-20240318, npm/scheduler@0.0.0-experimental-14898b6a9-20240318, npm/scheduler@0.24.0-canary-14898b6a9-20240318

View full report↗︎

@ztanner
Copy link
Copy Markdown
Contributor Author

ztanner commented Mar 18, 2024 •
edited
Loading

PR currently blocked on:

@ztanner ztanner changed the title Update React from 6c3b8dbfe to a870b2d54 Update React from 6c3b8dbfe to a4939017f Mar 21, 2024
@ztanner ztanner force-pushed the zt/upgrade-react branch 2 times, most recently from f04b33d to ce02b7e Compare March 21, 2024 22:34
@ztanner ztanner closed this Apr 2, 2024
@ztanner ztanner deleted the zt/upgrade-react branch April 2, 2024 13:10
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. locked type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ztanner @ijjk @gnoff
⚡