feat: Add htpasswd generator using helm. by pshanoop · Pull Request #69 · verdaccio/charts

pshanoop · 2021-07-01T17:32:08Z

Added support to have htpasswd credentails in helm values. So, a htpasswd file generated.

pshanoop · 2021-07-01T18:04:25Z

Kind failed to create a node. Is the lint script broken or should I increase timeout for helm ?

juanpicado · 2021-07-01T18:23:58Z

Fails on install, you might check the error

pshanoop · 2021-07-01T18:43:43Z

Fails on install, you might check the error

I have already installed this on my cluster,
Did you check the log? https://github.com/verdaccio/charts/pull/69/checks?check_run_id=2965258840#step:9:90 and
https://github.com/verdaccio/charts/pull/69/checks?check_run_id=2965258840#step:8:30

Anyway, I will add small change to retrigger this.

juanpicado · 2021-07-01T19:01:08Z

charts/verdaccio/values.yaml

    htpasswd:
-      file: /verdaccio/storage/htpasswd
+      # Do not change this path if secrets htpasswd is used.
+      file: /verdaccio/auth/htpasswd


I thought, It makes sense to use auth for authentication and storage only for package storage.
Besides, it would conflict with storage PVC.

juanpicado · 2021-07-01T19:05:32Z

Fails on install, you might check the error

I have already installed this on my cluster,
Did you check the log? https://github.com/verdaccio/charts/pull/69/checks?check_run_id=2965258840#step:9:90 and
https://github.com/verdaccio/charts/pull/69/checks?check_run_id=2965258840#step:8:30

Anyway, I will add small change to retrigger this.

I see this, I also triggered #70 and all is green.

Namespace 'verdaccio-xjtdpv878c' terminated.
Error: Error installing charts: Error processing charts
----------------------------------------------------------

pshanoop · 2021-07-01T19:09:44Z

Fails on install, you might check the error

I have already installed this on my cluster,
Did you check the log? https://github.com/verdaccio/charts/pull/69/checks?check_run_id=2965258840#step:9:90 and
https://github.com/verdaccio/charts/pull/69/checks?check_run_id=2965258840#step:8:30
Anyway, I will add small change to retrigger this.

I see this, I also triggered #70 and all is green.
Namespace 'verdaccio-xjtdpv878c' terminated.
Error: Error installing charts: Error processing charts
----------------------------------------------------------

On this, it skipped creating cluster and install.

This https://github.com/verdaccio/charts/runs/2654454267 good reference. Here I see install going through.

charts/verdaccio/templates/deployment.yaml

charts/verdaccio/templates/htpasswd-secret.yaml

juanpicado · 2021-07-01T19:37:05Z

Fails on install, you might check the error

I have already installed this on my cluster,
Did you check the log? https://github.com/verdaccio/charts/pull/69/checks?check_run_id=2965258840#step:9:90 and
https://github.com/verdaccio/charts/pull/69/checks?check_run_id=2965258840#step:8:30
Anyway, I will add small change to retrigger this.

I see this, I also triggered #70 and all is green.
Namespace 'verdaccio-xjtdpv878c' terminated.
Error: Error installing charts: Error processing charts
----------------------------------------------------------
On this, it skipped creating cluster and install.

This https://github.com/verdaccio/charts/runs/2654454267 good reference. Here I see install going through.

Yeah, something is broken, I do not why, we should wait until is green, maybe is just a hickup.

rblaine95 · 2021-07-02T11:25:35Z

charts/verdaccio/templates/deployment.yaml

    metadata:
      annotations:
        checksum/config: {{ include (print $.Template.BasePath "/configmap.yaml") . | sha256sum }}
+        checksum/htpasswd-secret: {{ include (print $.Template.BasePath "/htpasswd-secret.yaml") . | sha256sum }}


It may be better to hash .Values.secrets.htpasswd than the secret because the htpasswd function returns different output every time you run helm upgrade even though the actual users/passwords didn't change.

checksum/htpasswd: {{ sha256sum .Values.secrets.htpasswd }}

This way the checksum will only change when the actual user/passwords change and not because htpasswd returned different output for the same input for every helm upgrade

juanpicado · 2021-07-02T16:27:01Z

I've fixed the pipeline here #70 please approve and you can rebase on top of it.

pshanoop · 2021-07-02T16:48:14Z

Finally went through,
@juanpicado Thanks fixing, it. 👍🏾
@rblaine95 Thanks for reviewing. 👍🏾

juanpicado · 2021-07-03T08:29:29Z

Just a suggestion, I am learning helm and kubernettes, maybe you can expand your PR will an example configuration so :) I can try myself locally.

pshanoop · 2021-07-03T09:08:21Z

Just a suggestion, I am learning helm and kubernettes, maybe you can expand your PR will an example configuration so :) I can try myself locally.

Added an example section.

pshanoop · 2021-07-07T09:21:29Z

Just a friendly reminder, I have updated everything mentioned.

juanpicado

LGTM :) waiting @verdaccio/kubernetes experts to approve

marekaf

lgtm

juanpicado · 2021-07-07T19:45:42Z

@rblaine95 Can I merge?

rblaine95

I'm just thinking there must be a clean way to make the secret mount and config dynamic...
However, I think that can be done in a different PR.

This PR LGTM 👍

pshanoop · 2021-07-08T14:29:37Z

Thanks, @juanpicado, @marekaf and @rblaine95 .

juanpicado · 2021-07-08T14:30:07Z

Thank all of you for keep improving the chart!

pshanoop · 2021-07-08T14:30:55Z

I'm just thinking there must be a clean way to make the secret mount and config dynamic...
However, I think that can be done in a different PR.

This PR LGTM

I also feel the same, If you have some thoughts. Please put ideas on discussion thread. :)

Sanoob Pattanath and others added 5 commits July 1, 2021 14:18

Add support for AWS LoadBalancer Controller

388413c

Bump chart version

56c99d4

Remove empty line changes

60e5118

feat: Add htpasswd secret generator

648d637

Merge branch 'master' into htpasswd

144216a

Fix typo.

4bb43e5

juanpicado requested a review from a team July 1, 2021 19:00

juanpicado reviewed Jul 1, 2021

View reviewed changes

rblaine95 reviewed Jul 1, 2021

View reviewed changes

charts/verdaccio/templates/deployment.yaml Show resolved Hide resolved

rblaine95 reviewed Jul 1, 2021

View reviewed changes

charts/verdaccio/templates/htpasswd-secret.yaml Outdated Show resolved Hide resolved

rblaine95 reviewed Jul 1, 2021

View reviewed changes

charts/verdaccio/templates/htpasswd-secret.yaml Outdated Show resolved Hide resolved

pshanoop added 2 commits July 1, 2021 21:45

fix: typo, htpasswd-secret mounth path, htpasswd-secrets labels

ebe22c7

fix: htpasswd mount path

440550f

rblaine95 reviewed Jul 2, 2021

View reviewed changes

Merge branch 'master' into htpasswd

6f4c713

fix: checksum/htpasswd-secret for deployment

9ba15b0

juanpicado requested review from juanpicado and rblaine95 July 2, 2021 17:59

fix: checksum/htpasswd-secret on deployment.yaml

b3b978c

doc: Add example in readme.md

2793443

juanpicado approved these changes Jul 7, 2021

View reviewed changes

juanpicado requested a review from a team July 7, 2021 10:59

marekaf approved these changes Jul 7, 2021

View reviewed changes

rblaine95 approved these changes Jul 8, 2021

View reviewed changes

juanpicado merged commit aaa72b1 into verdaccio:master Jul 8, 2021

pshanoop deleted the htpasswd branch July 8, 2021 14:30

arthur2308 mentioned this pull request Jul 20, 2021

checking array if empty to remove redundant flag #71

Closed

Uh oh!

Conversation

pshanoop commented Jul 1, 2021

Uh oh!

pshanoop commented Jul 1, 2021

Uh oh!

juanpicado commented Jul 1, 2021

Uh oh!

pshanoop commented Jul 1, 2021

Uh oh!

juanpicado Jul 1, 2021

Choose a reason for hiding this comment

Uh oh!

pshanoop Jul 1, 2021

Choose a reason for hiding this comment

Uh oh!

juanpicado commented Jul 1, 2021

Uh oh!

pshanoop commented Jul 1, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

juanpicado commented Jul 1, 2021

Uh oh!

rblaine95 Jul 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rblaine95 Jul 2, 2021

Choose a reason for hiding this comment

Uh oh!

juanpicado commented Jul 2, 2021

Uh oh!

pshanoop commented Jul 2, 2021

Uh oh!

juanpicado commented Jul 3, 2021

Uh oh!

pshanoop commented Jul 3, 2021

Uh oh!

pshanoop commented Jul 7, 2021

Uh oh!

juanpicado left a comment

Choose a reason for hiding this comment

Uh oh!

marekaf left a comment

Choose a reason for hiding this comment

Uh oh!

juanpicado commented Jul 7, 2021

Uh oh!

rblaine95 left a comment

Choose a reason for hiding this comment

Uh oh!

pshanoop commented Jul 8, 2021

Uh oh!

juanpicado commented Jul 8, 2021

Uh oh!

pshanoop commented Jul 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rblaine95 Jul 2, 2021 •

edited

Loading