This repository was archived by the owner on Jan 16, 2022. It is now read-only.
Install Component - Replaced class by func. comp#152
Merged
juanpicado merged 8 commits intomasterfrom Oct 6, 2019
Merged
Conversation
priscilawebdev
added
good first issue
juanpicado
reviewed
Oct 3, 2019
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
==========================================
+ Coverage 82.97% 82.97% +<.01%
==========================================
Files 97 97
Lines 928 934 +6
Branches 163 163
==========================================
+ Hits 770 775 +5
- Misses 141 143 +2
+ Partials 17 16 -1
Continue to review full report at Codecov.
|
juanpicado
suggested changes
Oct 5, 2019
Member
juanpicado
left a comment
juanpicado
left a comment
There was a problem hiding this comment.
All installs says npm, perhaps we should check this scenario with a test.
Contributor
Author
|
@juanpicado good catch!! it should be fine now :-) |
delete-merged-branch
bot
deleted the
refactor/116_convert_class_to_func_Install
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: Refactor
The following has been addressed in the PR: #116
Unit or Functional tests are included in the PR?
Yes.
Description:
in order to use react hooks, in this PR I updated the Install component by changing it from a class to a functional component. I have also splitted it's content so that it is clearer.