Skip to content
This repository was archived by the owner on Jan 16, 2022. It is now read-only.

refactor: use function component for Install#154

Closed
antoinechalifour wants to merge 2 commits intoverdaccio:masterfrom
antoinechalifour:refactor/116_install-component
Closed

refactor: use function component for Install#154
antoinechalifour wants to merge 2 commits intoverdaccio:masterfrom
antoinechalifour:refactor/116_install-component

Conversation

@antoinechalifour
Copy link
Copy Markdown
Contributor

Type: refactor

The following has been addressed in the PR:

  • There is a related issue? #116
  • Unit or Functional tests are included in the PR : not changed

@priscilawebdev
Copy link
Copy Markdown
Contributor

Hi @antoinechalifourWe really appreciate your contribution, but we have a small problem: I created a PR yesterday with the same purpose. Please see:
image #152 I am really sorry.

@priscilawebdev
Copy link
Copy Markdown
Contributor

it's duplicated

@antoinechalifour
Copy link
Copy Markdown
Contributor Author

No worries, I didn't refresh my PR tab so I noticed it later! Nice job :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants