Skip to content
This repository was archived by the owner on Jan 16, 2022. It is now read-only.

fix: css repetition is not closed in Logo component#106

Merged
juanpicado merged 1 commit into4.x-masterfrom
bugfix-css-logo
Jul 15, 2019
Merged

fix: css repetition is not closed in Logo component#106
juanpicado merged 1 commit into4.x-masterfrom
bugfix-css-logo

Conversation

@sergiohgz
Copy link
Copy Markdown
Contributor

Type: fix

The following has been addressed in the PR:

  • There is a related issue? - No
  • Unit or Functional tests are included in the PR - Updated snapshots

Description: The CSS template was not closed

@sergiohgz sergiohgz requested a review from juanpicado July 15, 2019 12:45
@sergiohgz sergiohgz self-assigned this Jul 15, 2019
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #106 into 4.x-master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           4.x-master     #106   +/-   ##
===========================================
  Coverage       70.36%   70.36%           
===========================================
  Files              88       88           
  Lines             857      857           
  Branches          140      140           
===========================================
  Hits              603      603           
  Misses            245      245           
  Partials            9        9
Impacted Files Coverage Δ
src/components/Logo/Logo.tsx 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cad5ac9...ec243b1. Read the comment docs.

Copy link
Copy Markdown
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good catch

@juanpicado juanpicado merged commit 9343503 into 4.x-master Jul 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix-css-logo branch July 15, 2019 12:50
juanpicado added a commit to verdaccio/verdaccio that referenced this pull request Jul 29, 2019
- fix: https://github.com/verdaccio/ui/issues/76
- fix: https://github.com/verdaccio/ui/issues/75
- fix: verdaccio/ui#106
- feat: verdaccio/ui#47

Co-Authored-By: Priscila Oliveira <priscilawebdev@gmail.com>
Co-Authored-By: Sergio Hg <sergiohgz@users.noreply.github.com>
Co-Authored-By: Griffith <griffithtp@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants