This repository was archived by the owner on Jan 16, 2022. It is now read-only.
Merged
Conversation
Using React hooks
juanpicado
commented
Aug 12, 2019
| "@material-ui/core": "3.9.3", | ||
| "@material-ui/icons": "3.0.2", | ||
| "@octokit/rest": "16.28.7", | ||
| "@testing-library/react": "9.1.0", |
Member
Author
There was a problem hiding this comment.
I am adding this @testing-library/react for experimenting using the render method.
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
==========================================
+ Coverage 71.28% 73.66% +2.37%
==========================================
Files 88 89 +1
Lines 874 877 +3
Branches 156 157 +1
==========================================
+ Hits 623 646 +23
+ Misses 239 219 -20
Partials 12 12
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: refactor
The candidate here is
src/components/Developers/Developers.tsx.I extracted the Avatar to
src/components/AvatarTooltip/AvatarTooltip.tsx🆕The following has been addressed in the PR:
Description:
First try using hooks. Some notes:
useStateanduseContextusage.mountthe component.@testing-library/reactmight be useful in coordination withEnzyme.mountmount.