This repository was archived by the owner on Jan 16, 2022. It is now read-only.
fix(ui): fix the hover effect on the packageItem's author area#137
Merged
juanpicado merged 2 commits intoverdaccio:masterfrom Sep 29, 2019
FilipMessa:fix-hover-package-list
Merged
fix(ui): fix the hover effect on the packageItem's author area#137juanpicado merged 2 commits intoverdaccio:masterfrom FilipMessa:fix-hover-package-list
juanpicado merged 2 commits intoverdaccio:masterfrom
FilipMessa:fix-hover-package-list
Conversation
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
- Coverage 84.14% 84.12% -0.02%
==========================================
Files 92 92
Lines 927 926 -1
Branches 151 166 +15
==========================================
- Hits 780 779 -1
+ Misses 132 128 -4
- Partials 15 19 +4
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type:
bug
Description:
This should fix unwanted hover in PackageItem's author section.
Notes:
The issue here is that
PackageListItemhas the prop button astrue, but if I removed that or set to 'false' type-script complains that the button prop should be always set totrue.I don't have many experiences with the type-script, but I suppose that this issue is from the
material-uitypes.I came to with workaround but maybe there will be exist something better.
close #135