Skip to content
This repository was archived by the owner on Jan 16, 2022. It is now read-only.

fix(ui): fix the hover effect on the packageItem's author area#137

Merged
juanpicado merged 2 commits intoverdaccio:masterfrom
FilipMessa:fix-hover-package-list
Sep 29, 2019
Merged

fix(ui): fix the hover effect on the packageItem's author area#137
juanpicado merged 2 commits intoverdaccio:masterfrom
FilipMessa:fix-hover-package-list

Conversation

@FilipMessa
Copy link
Copy Markdown
Contributor

@FilipMessa FilipMessa commented Sep 29, 2019

Type:
bug

Description:
This should fix unwanted hover in PackageItem's author section.

Notes:
The issue here is that PackageListItem has the prop button as true, but if I removed that or set to 'false' type-script complains that the button prop should be always set to true.
I don't have many experiences with the type-script, but I suppose that this issue is from the material-ui types.

I came to with workaround but maybe there will be exist something better.

close #135

@juanpicado juanpicado self-requested a review September 29, 2019 14:36
Copy link
Copy Markdown
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really nice 🚀 welcome !

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #137 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
- Coverage   84.14%   84.12%   -0.02%     
==========================================
  Files          92       92              
  Lines         927      926       -1     
  Branches      151      166      +15     
==========================================
- Hits          780      779       -1     
+ Misses        132      128       -4     
- Partials       15       19       +4
Impacted Files Coverage Δ
src/components/Package/Package.tsx 100% <ø> (ø) ⬆️
src/components/Package/styles.ts 100% <ø> (ø) ⬆️
src/components/Header/Header.tsx 89.47% <0%> (ø) ⬆️
src/components/Install/Install.tsx 83.33% <0%> (ø) ⬆️
src/components/DetailSidebar/DetailSidebar.tsx 89.47% <0%> (ø) ⬆️
...mponents/RegistryInfoDialog/RegistryInfoDialog.tsx 66.66% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f61913c...7c37955. Read the comment docs.

@juanpicado juanpicado merged commit 2e50981 into verdaccio:master Sep 29, 2019
@juanpicado juanpicado added the bug label Sep 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSS issue on hover / material-ui

3 participants