This repository was archived by the owner on Jan 16, 2022. It is now read-only.
Refactor: Dependencies - Replaced with func. comp#169
Merged
priscilawebdev merged 3 commits intoverdaccio:masterfrom Oct 11, 2019
Merged
Conversation
antoinechalifour
commented
Oct 8, 2019
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
==========================================
+ Coverage 85.06% 88.15% +3.09%
==========================================
Files 107 107
Lines 924 912 -12
Branches 160 147 -13
==========================================
+ Hits 786 804 +18
+ Misses 124 95 -29
+ Partials 14 13 -1
Continue to review full report at Codecov.
|
antoinechalifour
force-pushed
the
refactor/116-dependencies_component
branch
from
093b2d1 to
795db38
Compare
antoinechalifour
force-pushed
the
refactor/116-dependencies_component
branch
from
795db38 to
7631d4d
Compare
juanpicado
reviewed
Oct 9, 2019
|
|
||
| test('Renders a link to each dependency', () => { | ||
| // Given | ||
| const packageMeta = { |
Contributor
There was a problem hiding this comment.
Maybe you could make the packageMeta reusable?
Contributor
Author
There was a problem hiding this comment.
I agree ! We should start implementing reusable fixtures for the whole project. My next PR ;)
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
How about we use this in a separate PR ?
antoinechalifour
force-pushed
the
refactor/116-dependencies_component
branch
from
7631d4d to
4e63ca2
Compare
priscilawebdev
approved these changes
Oct 11, 2019
Member
|
88% coverage great guys !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: refactor
The following has been addressed in the PR:
Description:
Moves
<Dependencies />to Function Component syntax.