This repository was archived by the owner on Jan 16, 2022. It is now read-only.
feat: i18n for UI via crowdin translations#198
Closed
juanpicado wants to merge 2 commits intomasterfrom
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
=======================================
Coverage 88.73% 88.73%
=======================================
Files 117 117
Lines 932 932
Branches 168 147 -21
=======================================
Hits 827 827
- Misses 89 92 +3
+ Partials 16 13 -3
|
Contributor
|
@juanpicado I am looking forward to have i18n in our code base! 💪👏 Kudos!! |
| "react-dom": "16.10.0", | ||
| "react-emotion": "9.2.12", | ||
| "react-hot-loader": "4.12.11", | ||
| "react-i18next": "10.13.1", |
Contributor
There was a problem hiding this comment.
Please why did you decided to use "react-i18next"?.. it's just matter of curiosity..I have never used this library before.
Contributor
|
closing, because it was already merged in this PR: #432 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: feat
Description:
react-i18nextResolves #102