This repository was archived by the owner on Jan 16, 2022. It is now read-only.
Improved Typings for API class#210
Merged
juanpicado merged 1 commit intoverdaccio:masterfrom Oct 22, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
=======================================
Coverage 86.95% 86.95%
=======================================
Files 117 117
Lines 874 874
Branches 160 160
=======================================
Hits 760 760
Misses 97 97
Partials 17 17
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes some
ts-ignoreinstructions that where placed around theAPIclass.No actual code changes, just more streamlined typings, even though I would like to rewrite the API class with async/await syntax later. But since there is nothing wrong with the actual promised based code I didn't for this PR.