This repository was archived by the owner on Jan 16, 2022. It is now read-only.
Merged
Conversation
Contributor
|
Did you add invalid for a reason? |
Contributor
Author
|
@sergiohgz yes... the code I removed doesn't seems right..hmm but actually it is the solution...I will remove the tag :) |
Codecov Report
@@ Coverage Diff @@
## master #406 +/- ##
=======================================
Coverage 87.72% 87.72%
=======================================
Files 137 137
Lines 953 953
Branches 211 198 -13
=======================================
Hits 836 836
- Misses 103 104 +1
+ Partials 14 13 -1
|
|
Thanks for your PR, the @verdaccio/ui package will be accessible from here for testing purposes: |
Contributor
|
If it doesn't seems right, does it really apply? |
Contributor
Author
|
@sergiohgz sorry...I confused you..my PR solves the problem 😉the removed file was not used |
Contributor
|
Aaaa, perfect 👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: Bug
Description:
Fixes #95