Skip to content
This repository was archived by the owner on Jan 16, 2022. It is now read-only.

feat: spanish translations to UI#440

Merged
juanpicado merged 2 commits intomasterfrom
feat-add-spanish-translations
Mar 9, 2020
Merged

feat: spanish translations to UI#440
juanpicado merged 2 commits intomasterfrom
feat-add-spanish-translations

Conversation

@juanpicado
Copy link
Copy Markdown
Member

@juanpicado juanpicado commented Mar 8, 2020

Type: feat

Description:

follow up of #432

Screen Shot 2020-03-08 at 6 30 13 PM

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 8, 2020

Codecov Report

Merging #440 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #440   +/-   ##
=======================================
  Coverage   88.08%   88.08%           
=======================================
  Files         140      140           
  Lines         982      982           
  Branches      216      204   -12     
=======================================
  Hits          865      865           
- Misses        105      106    +1     
+ Partials       12       11    -1     
Impacted Files Coverage Δ
src/components/Icon/styles.ts 88.88% <0.00%> (ø)

@juanpicado juanpicado requested review from a team and priscilawebdev March 8, 2020 17:31
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@verdacciobot
Copy link
Copy Markdown

Thanks for your PR, the @verdaccio/ui package will be accessible from here for testing purposes:

npm install @verdaccio/ui-theme@v0.3.14-bc97612-pr440.0 --registry https://registry.verdaccio.org

Copy link
Copy Markdown
Member

@anikethsaha anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@juanpicado juanpicado merged commit 0abe1ef into master Mar 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the feat-add-spanish-translations branch March 9, 2020 06:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants