Skip to content
This repository was archived by the owner on Jan 16, 2022. It is now read-only.

feat(style): added dark mode #446

Merged
priscilawebdev merged 12 commits into from
Mar 31, 2020
Merged

feat(style): added dark mode #446

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
26b484e
feat(style): added dark mode
priscilawebdev Mar 22, 2020
6b7ed8a
Merge branch 'master' into feat/add-dark-mode
priscilawebdev Mar 22, 2020
76cda8f
Delete .secrets-baseline
priscilawebdev Mar 22, 2020
f2565a0
feat(style): added dark mode
priscilawebdev Mar 22, 2020
f50f5c7
Merge branch 'feat/add-dark-mode' of github.com:verdaccio/ui into fea…
priscilawebdev Mar 22, 2020
2498830
Merge branch 'feat/add-dark-mode' of github.com:verdaccio/ui into fea…
priscilawebdev Mar 22, 2020
c741b03
Merge branch 'feat/add-dark-mode' of github.com:verdaccio/ui into fea…
priscilawebdev Mar 22, 2020
4daa949
added one translation
priscilawebdev Mar 22, 2020
18b8dd8
updated snaps
priscilawebdev Mar 22, 2020
467072e
added env var dark_mode
priscilawebdev Mar 25, 2020
abb67bd
fixed var
priscilawebdev Mar 26, 2020
cab2984
added useLocalStorage
priscilawebdev Mar 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ export interface VerdaccioOptions {
url_prefix: string;
base: string;
language?: string;
darkMode?: boolean;
dark_mode?: boolean;
Copy link
Copy Markdown
Member

@juanpicado juanpicado Mar 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer cammelCase, hopefully we can remove some day all the _ ...

Copy link
Copy Markdown
Contributor Author

@priscilawebdev priscilawebdev Mar 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

me too, but then I noticed that we have url_prefix and I decided to do like this

Copy link
Copy Markdown
Member

@juanpicado juanpicado Mar 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

url_prefix is from the sinopia era, the previous author was quite all over the place using that, it took me few years to get rid of those, but some configurations are still using _ due backward compatibility unfortunately.

}

declare global {
Expand Down
⚡