Skip to content
This repository was archived by the owner on Jan 16, 2022. It is now read-only.

feat: added zh-CN translations to the UI#448

Merged
priscilawebdev merged 5 commits intoverdaccio:masterfrom
JackyChan:master
Apr 2, 2020
Merged

feat: added zh-CN translations to the UI#448
priscilawebdev merged 5 commits intoverdaccio:masterfrom
JackyChan:master

Conversation

@JackyChan
Copy link
Copy Markdown
Contributor

added zh-CN translations to the UI

Type:

The following has been addressed in the PR:

  • There is a related issue?
  • Unit or Functional tests are included in the PR

Description:

added zh-CN translations to the UI
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2020

Codecov Report

Merging #448 into master will decrease coverage by 0.25%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
- Coverage   85.47%   85.22%   -0.26%     
==========================================
  Files         141      141              
  Lines        1019     1022       +3     
  Branches      210      210              
==========================================
  Hits          871      871              
- Misses        122      125       +3     
  Partials       26       26              
Impacted Files Coverage Δ
i18n/config.ts 100.00% <ø> (ø)
src/App/load-dayjs-locale.ts 29.16% <0.00%> (-4.17%) ⬇️

@juanpicado
Copy link
Copy Markdown
Member

Awesome 👏🏻!

juanpicado
juanpicado previously approved these changes Mar 30, 2020
@priscilawebdev
Copy link
Copy Markdown
Contributor

@JackyChan great job 👌 Please before we merge it, could you please also add the locale
zh-CN here?

https://github.com/verdaccio/ui/blob/master/src/App/load-dayjs-locale.ts

After that we are good to go :)

Copy link
Copy Markdown
Contributor

@priscilawebdev priscilawebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@JackyChan
Copy link
Copy Markdown
Contributor Author

@JackyChan great job 👌 Please before we merge it, could you please also add the locale
zh-CN here?

https://github.com/verdaccio/ui/blob/master/src/App/load-dayjs-locale.ts

After that we are good to go :)

Ok, it's done.

Copy link
Copy Markdown
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

非常感謝你對這個項目的貢獻,感激不盡!😉

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Copy Markdown
Contributor

@priscilawebdev priscilawebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🚀thanks @JackyChan

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants