Skip to content
This repository was archived by the owner on Jan 16, 2022. It is now read-only.

feat: add chinese trad for taiwan translations#486

Merged
priscilawebdev merged 4 commits intoverdaccio:masterfrom
tso1158687:translation-chinese-traditional
Jun 7, 2020
Merged

feat: add chinese trad for taiwan translations#486
priscilawebdev merged 4 commits intoverdaccio:masterfrom
tso1158687:translation-chinese-traditional

Conversation

@tso1158687
Copy link
Copy Markdown
Contributor

feat(lang): add chinese traditional language for Taiwanese

Type: translation

The following has been addressed in the PR:

There is a related issue?
NO
Unit or Functional tests are included in the PR
NO
Description: Add Chinese Traditional translations for Taiwanese (zh-TW)

@tso1158687 tso1158687 force-pushed the translation-chinese-traditional branch 2 times, most recently from b48439c to 7637b99 Compare June 5, 2020 04:09
@juanpicado
Copy link
Copy Markdown
Member

feat(lang): add chinese traditional language for Taiwanese

Type: translation

The following has been addressed in the PR:

There is a related issue?

NO

Unit or Functional tests are included in the PR

NO

Description: Add Chinese Traditional translations for Taiwanese (zh-TW)

Awesome !!! Thanks 😊 (btw I love Taiwan, my last visit was priceless)

@juanpicado
Copy link
Copy Markdown
Member

@tso1158687 could you rebase? I just merged a new feature wich conflict with your code.

@tso1158687
Copy link
Copy Markdown
Contributor Author

btw I love Taiwan, my last visit was priceless

Thanks for loving Taiwan 😄

@tso1158687
Copy link
Copy Markdown
Contributor Author

@tso1158687 could you rebase? I just merged a new feature wich conflict with your code.

Sure, I'll rebase it

@tso1158687 tso1158687 force-pushed the translation-chinese-traditional branch 4 times, most recently from 07522dc to be23af6 Compare June 5, 2020 09:28
feat(lang): add chinese traditional language for Taiwanese
@tso1158687 tso1158687 force-pushed the translation-chinese-traditional branch from be23af6 to bbaa8e5 Compare June 5, 2020 09:33
@juanpicado juanpicado requested a review from priscilawebdev June 5, 2020 10:36
juanpicado
juanpicado previously approved these changes Jun 5, 2020
Copy link
Copy Markdown
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally

const optionLabel = useCallback(({ translation }: ReturnType<typeof getCurrentLngDetails>) => translation, [
getCurrentLngDetails,
]);
// prettier-ignore
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please why did you add 'prettier-ignore' here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not pass lint check because of this line, but I don't know how to fix it.
So I add prettier-ignore to try but I forget removing this.
Sorry for confused you

@priscilawebdev
Copy link
Copy Markdown
Contributor

@tso1158687 Good Job! Thank you!.. if you don't mind I will update the snapshots, so we can merge it 😉🙂

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jun 7, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.1% 8.1% Duplication

Copy link
Copy Markdown
Contributor

@priscilawebdev priscilawebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@priscilawebdev priscilawebdev merged commit bc4a246 into verdaccio:master Jun 7, 2020
@tso1158687
Copy link
Copy Markdown
Contributor Author

@tso1158687 Good Job! Thank you!.. if you don't mind I will update the snapshots, so we can merge it 😉🙂

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants