Skip to content
This repository was archived by the owner on Jan 16, 2022. It is now read-only.

fix: error on header color in dark mode #478#490

Merged
priscilawebdev merged 1 commit intoverdaccio:masterfrom
VentyCZ:verdaccio-478
Jun 14, 2020
Merged

fix: error on header color in dark mode #478#490
priscilawebdev merged 1 commit intoverdaccio:masterfrom
VentyCZ:verdaccio-478

Conversation

@VentyCZ
Copy link
Copy Markdown
Member

@VentyCZ VentyCZ commented Jun 13, 2020

-->
Type: bug

Description:

Resolves #478 - Registry Info window has wrong header style in Dark mode

I tried multiple colors, so no other components break with this change (see https://github.com/verdaccio/ui/issues/478#issuecomment-643599923).

image

Registry Info window has wrong header style in Dark mode
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@VentyCZ VentyCZ requested a review from priscilawebdev June 13, 2020 10:27
Copy link
Copy Markdown
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! 🚀

@juanpicado juanpicado changed the title fix: #478 fix: error on header color in dark mode #478 Jun 13, 2020
Copy link
Copy Markdown
Contributor

@priscilawebdev priscilawebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really Nice! Thank youuu

@priscilawebdev priscilawebdev merged commit e9d0729 into verdaccio:master Jun 14, 2020
@juanpicado
Copy link
Copy Markdown
Member

@all-contributors please add @VentyCZ for code

@allcontributors
Copy link
Copy Markdown
Contributor

@juanpicado

I've put up a pull request to add @VentyCZ! 🎉

@juanpicado
Copy link
Copy Markdown
Member

@all-contributors please add @priscilawebdev for maintainer

@allcontributors
Copy link
Copy Markdown
Contributor

@juanpicado

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@juanpicado
Copy link
Copy Markdown
Member

@all-contributors please add @VentyCZ for maintenance

@allcontributors
Copy link
Copy Markdown
Contributor

@juanpicado

I've updated the pull request to add @VentyCZ! 🎉

@VentyCZ VentyCZ deleted the verdaccio-478 branch June 20, 2020 07:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Registry Info window has wrong header style in Dark mode

3 participants