This repository was archived by the owner on Jan 16, 2022. It is now read-only.
fix: search suggestion container height#54
Merged
juanpicado merged 2 commits into4.x-masterfrom May 11, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## 4.x-master #54 +/- ##
==============================================
+ Coverage 85.12% 85.15% +0.02%
==============================================
Files 55 55
Lines 531 532 +1
Branches 69 69
==============================================
+ Hits 452 453 +1
Misses 66 66
Partials 13 13
Continue to review full report at Codecov.
|
DanielRuf
reviewed
May 11, 2019
| export const SuggestionContainer = styled(Paper)` | ||
| && { | ||
| max-height: 500px; | ||
| overflow-y: scroll; |
Contributor
There was a problem hiding this comment.
Should be probably auto as otherwise you always have a scrollbar in some browsers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
Description: